warpdotdev / Warp

Warp is a modern, Rust-based terminal with AI built in so you and your team can build great software, faster.
https://warp.dev
Other
21.58k stars 379 forks source link

Global hotkey got broken after mac sleep #3275

Open mulecalle opened 1 year ago

mulecalle commented 1 year ago

Discord username (optional)

No response

Describe the bug

I have two displays:

Screenshot 2023-06-28 at 21 36 31

Warp recognizes the external display C27JG5x as Screen 2 and Built-in Retina as Main screen.

The following Global hotkey configuration used to work well, however since some releases ago after I wake up the Mac from sleep the terminal is always open/closed in the Main screen

Screenshot 2023-06-28 at 21 34 22

To reproduce

  1. Go to Settings, then Features and apply the following configuration:

    Screenshot 2023-06-28 at 21 34 22
  2. Press ⌥W, then verify that Warp is open in the Screen 2

  3. Put the Mac to sleep

  4. Wake up the Mac

  5. Press ⌥W

Actual Behaviour Warp is open in the Main Screen

Expected behavior

Warp is open in the Screen 2

Screenshots

No response

Operating system

MacOS

Operating system and version

13.4 (22F66)

Shell Version

GNU bash, version 3.2.57(1)-release (x86_64-apple-darwin22)

Current Warp version

v0.2023.06.20.08.04.stable_03

Regression

Yes, this bug started recently or with an X Warp version

Recent working Warp date

No response

Additional context

No response

Does this block you from using Warp daily?

No

Is this a Warp specific issue? (i.e. does it happen in Terminal, iTerm, Kitty, etc.)

Yes, this I confirmed this only happens in Warp, not other terminals.

Warp Internal (ignore): linear-label:b8107fdf-ba31-488d-b103-d271c89cac3e

None

dannyneira commented 1 year ago

Hi @mulecalle I've found this difficult to reproduce. What I recommend to fix this is to make sure the display is set to "Main Display" in the Arrange settings so that the other display will be Display 2.

https://github.com/warpdotdev/Warp/assets/16809145/8329c8fd-d5ab-489d-9541-467d281f5672

If the issue persists, please try and close the Dedicated window by pressing CMD-W with it open and focused. Then it will generate a new window in the proper display as your new customization will apply the next time a Dedicated Window is created, not the currently opened one.

mulecalle commented 1 year ago

Hi, @dannyneira thank you for your response, this video was captured in the main display after a wake-up from sleep. Warp is opened/closed by pressing the keybinding configuration (⌥W)

https://github.com/warpdotdev/Warp/assets/48928350/6fc38067-a87a-483d-a870-195d0a435f9b

As you can see the issue persists. I also tried your recommendations and it works however it's kind of annoying closing and re-opening.

dannyneira commented 1 year ago

Thanks for confirming. We'll post any further updates on this thread if/when this is being worked on/completed.

derlin commented 1 year ago

I have this annoying issue as well for a long time, and it is driving me nuts. My setting is to open on the main screen, but after sleep it often switches to another one. I need to go to settings, set open to active screen, toggle twice, and change the setting back. I really hope this issue gets some attention and care !

paul-voelker commented 9 months ago

Is there any update on this? I love Warp but this bug messes with my flow on a regular basis, it would be really great if this could be fixed, thanks!

milosdjakovic commented 9 months ago

I often encounter issues with all three screen options: Active Screen, Main Screen, and Screen 2.

Here's what usually happens when I invoke Warp using the global hotkey:

Switching screen setting doesn't resolve the issue, but restarting Warp temporarily fixes this issue.

I would say that the problem usually occurs when waking up my MacBook or when attaching/detaching external displays.

silent-tan commented 8 months ago

still happen sometime, it pushes me still use item2 for my primary tool : (

itmustbejj commented 4 months ago

I don't even need sleep for it to do this anymore. It just randomly switches when it feels like it.

paul-voelker commented 2 months ago

Any update on this? It would be really great to have this fixed 🥺

dannyneira commented 2 months ago

Hey folks, as a possible workaround to this issue, You may need to go to Mac > System Settings > Desktop & Dock , then enable "Displays have separate Spaces" and the "Active" screen hotkey settings should work after sleep. Please let us know if that helps with your issue.

dannyneira commented 1 month ago

A user commented on #5352

But doing that, it only works properly if I have nothing in fullscreen mode on the Active screen. At the moment that I open an App in fullscreen, then using the hotkey opens the Warp terminal in the other screen.