warpdotdev / Warp

Warp is a modern, Rust-based terminal with AI built in so you and your team can build great software, faster.
https://warp.dev
Other
20.83k stars 353 forks source link

Full screen presentation on macOS #3281

Open bloomingbridges opened 1 year ago

bloomingbridges commented 1 year ago

Discord username (optional)

bloomingbridges

Describe the bug

I'm hesitant to log this as a bug, but I've been using Warp for a couple months now and I feel like this only changed recently, so there is a chance it's unintentional.

Whenever I put Warp in full screen mode the rounded corners are still being drawn, so it basically looks like a blown up window rather than a full screen application.

To reproduce

  1. Go into fullscreen mode by either pressing the green button in the app's title bar or selecting "Window > Enter Full Screen"

Expected behavior

Expecting the window chrome to disappear to reduce distracting elements on screen.

Screenshots

Screenshot 2023-06-30 at 12 00 00

Operating system

MacOS

Operating system and version

13.4.1

Shell Version

No response

Current Warp version

v0.2023.06.27.19.34.stable_01

Regression

Yes, this bug started recently or with an X Warp version

Recent working Warp date

No response

Additional context

No response

Does this block you from using Warp daily?

No

Is this a Warp specific issue? (i.e. does it happen in Terminal, iTerm, Kitty, etc.)

Yes, this I confirmed this only happens in Warp, not other terminals.

Warp Internal (ignore): linear-label:b8107fdf-ba31-488d-b103-d271c89cac3e

None

dannyneira commented 1 year ago

Hi @bloomingbridges Thanks for submitting this. Could you please provide a video of the issue? based on your screenshots I can't see what the problem is, Warp appears to be fullscreen like normal. If you happen to have the mouse hovering on the top of the screen it will show your menu bar while in fullscreen mode as with other apps.

bloomingbridges commented 1 year ago

@dannyneira Sure thing! Here you go.

When going into full screen mode, the Warp window still has like a 1px outline and showing the window corners on an arbitrary background, whereas before they just "blended in" for the lack of a better word?

To illustrate the issue better here is a mockup:

Warp_issue#3281

Hope that made sense 💜

dannyneira commented 1 year ago

That makes sense, thanks for clarifying. I think this may have been an intentional design change, but I'll confirm and post any updates on the thread.

bloomingbridges commented 1 year ago

Awesome, thank you very much!

I'm sure I'd get used to it eventually, though for something as minimalist as a terminal app to stand out like that struck me as odd is all.

NathanielInman commented 6 months ago

2024-02-22_11-12

Now that it's available on linux, perhaps we can have an "Appearance" option to simply disable rounded corners. It's still functional, just doesn't mesh with other native applications in a variety different desktop environments.

azaleacolburn commented 2 months ago

Are there plans to address this in the future?