warpdotdev / Warp

Warp is a modern, Rust-based terminal with AI built in so you and your team can build great software, faster.
https://warp.dev
Other
21.44k stars 375 forks source link

Support dvorak-qwerty keyboard input #3312

Open iansmith opened 1 year ago

iansmith commented 1 year ago

Discord username (optional)

iansmith

Describe the bug

I use the Dvorak-Qwerty keyboard layout on my Mac. The title of this issue with what appears gobbledygook is what I get when I have warp set to work properly with tabs.

The next and prev don't work on the Dvorak-Qwerty layout but oddly do work if I switch my key back to "US" (which is qwerty).

To reproduce

1) Go to keyboard layouts in the system settings.

2) On the left panel use the + to add a new keyboard layout.

3) Add Dvorak-Qwerty as your layout.

4) Switch back to warp, and use Command-T to create a new tab.

5) Try using Command-Shift-{. or Command-Shift-}

It will work if you reset the keyboard layout to "US".

Expected behavior

I expected Warp to switch tabs using the standard Mac keybindings for prev and next tab.

Screenshots

No response

Operating system

MacOS

Operating system and version

Ventura 13.3.1

Shell Version

zsh

Current Warp version

v0.2023.06.27.19.34.stable_01

Regression

No, this bug or issue has existed throughout my experience using Warp

Recent working Warp date

No response

Additional context

I realize that me and the guy at apple who invented the Dvorak-Qwerty layout at Apple might seem like a small group of people. But we want to use Warp....

Does this block you from using Warp daily?

Yes, this issue prevents me from using Warp daily.

Is this a Warp specific issue? (i.e. does it happen in Terminal, iTerm, Kitty, etc.)

Yes, this I confirmed this only happens in Warp, not other terminals.

Warp Internal (ignore): linear-label:b8107fdf-ba31-488d-b103-d271c89cac3e

None

dannyneira commented 1 year ago

Thanks for letting us know @iansmith This is an issue with non-us(standard qwerty) keyboards not registering keyboard shortcuts properly. A couple of workaround options which include, 1. change your input method to qwerty-us input or 2. rebind all your shortcuts in the settings > keyboard shortcuts to see if that helps with the issue.

We're tracking the main issue over at #341 but I think we'll keep this open as a feature request to support dvorak-qwerty.

Please add a :+1: to the original post at the top to signal that you want this feature, and then hit the subscribe button if you'd like to be notified.