search

warpdotdev / Warp

Warp is a modern, Rust-based terminal with AI built in so you and your team can build great software, faster.
https://warp.dev
Other
21.3k stars 371 forks source link

aliases like "..." and "...." in zsh/ohmyzsh would be incorrectly underlined with red lines #3409

Closed Saafo closed 1 year ago

Saafo commented 1 year ago

Discord username (optional)

Saafo

Describe the bug

aliases like "..."(for "../..") and "...."(for "../../..") would be incorrectly underlined with red lines

To reproduce

  1. install zsh and ohmyzsh
  2. type "..." or "...."
  3. it will be incorrectly underlined

Expected behavior

The word is green and no underline

Screenshots

No response

Operating system

MacOS

Operating system and version

13.4

Shell Version

No response

Current Warp version

v0.2023.07.18.08.03.stable_00

Regression

No, this bug or issue has existed throughout my experience using Warp

Recent working Warp date

No response

Additional context

No response

Does this block you from using Warp daily?

No

Is this a Warp specific issue? (i.e. does it happen in Terminal, iTerm, Kitty, etc.)

Yes, this I confirmed this only happens in Warp, not other terminals.

Warp Internal (ignore): linear-label:b8107fdf-ba31-488d-b103-d271c89cac3e

None

dannyneira commented 1 year ago

hey @Saafo Thanks for letting us know. I was able to reproduce this issue with the underlines in oh-my-zsh. As a workaround, I recommend you disable the error underlining. We'll post any updates on this thread.

To anyone else facing this issue, please add a :+1: to the original post at the top or comment with your details, and subscribe if you'd like to be notified.

Saafo commented 1 year ago

Fixed in the latest release!

AlecRust commented 1 year ago

Looks like e.g. npm still underlines

image
Saafo commented 1 year ago

npm works fine for me

image
dannyneira commented 1 year ago

@AlecRust If npm has been recently installed, you need to open a new session for the underlines to go away. https://docs.warp.dev/features/editor/syntax-error-highlighting#what-is-error-underlining

AlecRust commented 1 year ago

@dannyneira thanks, but I've had npm installed for a while.

I see it works for some people like @Saafo, where npm is not underlined as an invalid command, and the syntax highlighting is even working. It looks like these issues are connected, and neither is working for me. I created #3772 about the command highlighting specifically.

My npm/Node is installed via rtx instead of Homebrew, that's the only difference I'm aware of though.

image

The npm command works fine, Warp just doesn't seem to recognize it.