warpdotdev / Warp

Warp is a modern, Rust-based terminal with AI built in so you and your team can build great software, faster.
https://warp.dev
Other
21.32k stars 372 forks source link

Synchronized Inputs: option "Synchronized all panels in current tab" working wrong behaviors #3437

Open bds-congnguyen opened 1 year ago

bds-congnguyen commented 1 year ago

Discord username (optional)

No response

Describe the bug

when open two tab which enabled Synchronized all panels in current tab will send broadcast input to all tabs instead of on active tab

To reproduce

  1. Open a tab
  2. Go to Edit -> Synchronized Inputs -> Synchronized all panels in current tab
  3. Open another tab
  4. Go to Edit -> Synchronized Inputs -> Synchronized all panels in current tab
  5. Type any command like echo "hello"
  6. Go back to tab at step 1
  7. Notice that command echo "hello" also sent to tab at step 1

Expected behavior

No response

Screenshots

No response

Operating system

MacOS

Operating system and version

13.3 (22E252)

Shell Version

No response

Current Warp version

v0.2023.07.18.08.03.stable_00

Regression

No, this bug or issue has existed throughout my experience using Warp

Recent working Warp date

No response

Additional context

No response

Does this block you from using Warp daily?

No

Is this a Warp specific issue? (i.e. does it happen in Terminal, iTerm, Kitty, etc.)

Yes, this I confirmed this only happens in Warp, not other terminals.

Warp Internal (ignore): linear-label:b8107fdf-ba31-488d-b103-d271c89cac3e

None

warpdotdev-devx[bot] commented 1 year ago

Hey @bds-congnguyen I'm not 100% sure this is a bug, it may be intentional so that you can be selective about which tabs you'd like to sync. For example, there is the Sync all tabs option, but that may not be the use case for someone who just wants to sync two out of three tabs, so we've added the ability to selectively sync/stop-sync on tabs. I'll add a note to our docs to help clarify this. https://docs.warp.dev/features/entry/synchronized-inputs

So in your case, are you expecting when you sync a tab for Warp to automatically un-sync other tabs? If so, we may need to change this to a feature request.

bds-congnguyen commented 1 year ago

we've added the ability to selectively sync/stop-sync on tabs

I think it make confuse since "Synchronize All Panes in CURRENT Tab", then current should keep it mean is only current TAB (not tabs).

I just double checked with function Broadcast Input to All Panes in Current Tab in Iterm then it work as I expected.

I suggest it's a bug. and if someone wants to sync two out of three tabs then I suggest a new function like Synchronize All Panes in Group Tab

dannyneira commented 1 year ago

There are no Tab groups in Warp currently. I believe you can also "sync all tabs", and then "Stop sync on the current tab", or you can individually toggle "Sync/stop sync current tab" on the ones you want to sync/unsync selectively. The feature may work a bit differently than in iTerm, but I hope this helps with your issue and use case.

https://github.com/warpdotdev/Warp/assets/16809145/97fcdb3f-3ad6-47d7-856b-333d7fe11aeb

Jesse-duanji commented 1 year ago

@dannyneira I think item2 is a better way. It's dangerous when you forget to stop sync on the current tab. You think you are working on the current tab, and you type "rm -rf *" Also it's a powerful feature to send commands across tabs. Can you at least provide a new way to just sync on the current tab and the old tab sync will be canceled?

liamjones commented 3 weeks ago

This bit me today. I also read "Synchronize All Panes in Current Tab" as working the same way as iTerm2 (esp as it uses the same shortcut).

A use case I often use it for in iTerm 2:

I will have enabled sync in tab 1 and enabled it in tab 2. With iTerm2's behaviour, it only broadcasts input to the visible tab, it's like two different sync 'groups'.

I'll broadcast input to tab 1 to make a change on all servers in environment 1, and then when I'm happy with it I'll repeat this in Tab 2 to update the servers in environment 2.

I'll have to train myself to open a new window rather than a tab in Warp to do this for now I guess

liamjones commented 3 weeks ago

If nothing else, I think "in current tab" is misleading and should change to "in current window".