warpdotdev / Warp

Warp is a modern, Rust-based terminal with AI built in so you and your team can build great software, faster.
https://warp.dev
Other
21.52k stars 376 forks source link

Git branch autocomplete for diff + log commands #3805

Open apolzon opened 1 year ago

apolzon commented 1 year ago

Discord username (optional)

No response

Describe the bug

the git checkout command's autocomplete is amazing, and was the #1 thing that got me to give Warp a shot in the first place. However, both git log and git diff do not allow for branch autocompletion.

For log, the autocomplete box has a list of commitishes but no branch options For diff, the behavior is a little better -- it will include locally changed files in the autocomplete box, but after that it is again just a list of commit SHAs

To reproduce

Type git log or git diff and observe the autocomplete box options

Expected behavior

Every git command where branches are relevant should include branches in the autocomplete options list. git log should include branches at the top of the list, while git diff should include branches after locally changed files. For both scenarios, the same fuzzy-search behavior that git checkout uses should be applied

Screenshots

No response

Operating system

MacOS

Operating system and version

14.0

Shell Version

zsh 5.9

Current Warp version

v0.2023.10.17.08.03.stable_02

Regression

No, this bug or issue has existed throughout my experience using Warp

Recent working Warp date

never

Additional context

To ensure this was not an issue specific to my zsh config, I also tested using a warpified bash shell opened from within my zsh environment, and the behavior was identical

Does this block you from using Warp daily?

No

Is this a Warp specific issue? (i.e. does it happen in Terminal, iTerm, Kitty, etc.)

Yes, this I confirmed this only happens in Warp, not other terminals.

Warp Internal (ignore): linear-label:b8107fdf-ba31-488d-b103-d271c89cac3e

None

dannyneira commented 1 year ago

Hey @apolzon Thanks for letting us know. I'll talk about the issue with the team and let you know if there are any updates on this thread. As a possible workaround, you can manually type in the branch name, and it should show the appropriate git diff/log.

To anyone else facing this issue, please add a :+1: to the original post at the top or comment with your details, and subscribe if you'd like to be notified.

UndiedGamer commented 4 months ago

any update on this?