warpdotdev / Warp

Warp is a modern, Rust-based terminal with AI built in so you and your team can build great software, faster.
https://warp.dev
Other
21.54k stars 377 forks source link

ESC no longer deselects bookmarked blocks when navigating with OPT-UP/DOWN #3869

Open dannyneira opened 1 year ago

dannyneira commented 1 year ago

Discord username (optional)

@DogaArmangil

Describe the bug

When Bookmarked blocks are selected with OPT-UP/DOWN, you can no longer use ESC to deselect them.

To reproduce

Please note that once a bookmarked block is selected with OPT-UP/DOWN, even if you select a regular block with CMD-UP/DOWN, ESC will not deselect, unless you do the workaround noted below.

Setup:

Expected behavior

ESC should deselect any selected block, regardless of how it was selected and if it has a bookmark or not.

Screenshots

Video of bug with workaround (switching tabs)

https://github.com/warpdotdev/Warp/assets/16809145/2534f4da-bf37-40ab-8166-65a73dea0098

Operating system

MacOS

Operating system and version

Sonoma 14.0

Shell Version

zsh 5.9

Current Warp version

v0.2023.11.07.08.02.stable_00

Regression

Yes, this bug started recently or with an X Warp version

Recent working Warp date

11/06/2023

Additional context

Workaround steps

Does this block you from using Warp daily?

No

Is this a Warp specific issue? (i.e. does it happen in Terminal, iTerm, Kitty, etc.)

Yes, this I confirmed this only happens in Warp, not other terminals.

Warp Internal (ignore): linear-label:b8107fdf-ba31-488d-b103-d271c89cac3e

None

dannyneira commented 1 year ago

We'll post any updates on this thread.

To anyone else facing this issue, please add a :+1: to the original post at the top or comment with your details, and subscribe if you'd like to be notified.