warpdotdev / Warp

Warp is a modern, Rust-based terminal with AI built in so you and your team can build great software, faster.
https://warp.dev
Other
21.21k stars 365 forks source link

Custom themes not showing up, improve parse error messaging #3884

Open dweslynch opened 11 months ago

dweslynch commented 11 months ago

Discord username (optional)

Aetalix

Describe the bug

I've added custom themes to the ~/.warp/themes directory, but they are not showing up in the theme selector in Warp. It's been like this for months.

To reproduce

I'm not sure how to reproduce this, since for other people it works fine

Expected behavior

The custom themes I've added appear in the theme selector

Screenshots

Screenshot 2023-11-17 at 2 10 58 PM

Operating system

MacOS

Operating system and version

MacOS Ventura 13.4.1

Shell Version

zsh 5.9 (x86_64-apple-darwin22.0)

Current Warp version

v0.2023.11.14.08.02.stable_02

Regression

No, this bug or issue has existed throughout my experience using Warp

Recent working Warp date

Has never worked for me

Additional context

No response

Does this block you from using Warp daily?

No

Is this a Warp specific issue? (i.e. does it happen in Terminal, iTerm, Kitty, etc.)

Yes, this I confirmed this only happens in Warp, not other terminals.

Warp Internal (ignore): linear-label:b8107fdf-ba31-488d-b103-d271c89cac3e

None

dannyneira commented 11 months ago

Hey @dweslynch, please check and make sure your permissions are similar to mine for those folders (~/.warp/ & ~/.warp/themes), and try and restart Warp to see if the theme shows up. If that doesn't help, please post a copy of the theme on this thread, and we can try to reproduce the issue.

CleanShot 2023-11-17 at 16 43 58

dannyneira commented 11 months ago

@dweslynch any luck with the above?

jvantuyl commented 10 months ago

Looks like it's failing to parse your YAML and doesn't really indicate that anywhere.

Specifically, look at terminal_colors -> light -> cyan. Notice the space after the color? When I remove that, the theme loads for me.

moooooo16 commented 8 months ago

You can't use capital letter. In my case I change all to lower case, and it worked.

lightify97 commented 4 weeks ago

I had the same issue on Linux (Ubuntu). Placing the theme in ~/.warp/themes didn't work. But copying the same to ~/.local/share/warp-terminal/themes worked.

jcnmsg commented 1 day ago

I had the same issue on Linux (Ubuntu). Placing the theme in ~/.warp/themes didn't work. But copying the same to ~/.local/share/warp-terminal/themes worked.

Same thing on Linux Mint DE.