warpdotdev / Warp

Warp is a modern, Rust-based terminal with AI built in so you and your team can build great software, faster.
https://warp.dev
Other
21.31k stars 371 forks source link

A unwanted script gets injected when opening warp with `fish` as default shell #4013

Open jatindotdev opened 10 months ago

jatindotdev commented 10 months ago

Discord username (optional)

No response

Describe the bug

maybe some pre script is getting injected and this too only happens in warp, i also looked at the fish config there nothing that does that, this doesn’t happen in any other terminal and the script fails which shows warning and also slows the startup time

To reproduce

  1. Set fish as default shell
  2. Open warp

Expected behavior

Maybe no to run any prescript that fails or idk what happening here

Screenshots

https://github.com/warpdotdev/Warp/assets/59236972/40538c3e-4570-40c6-b51e-b703d744b60f

Operating system

MacOS

Operating system and version

Sonoma 14.2.1 (23C71)

Shell Version

fish, version 3.6.4

Current Warp version

v0.2023.12.19.08.02.stable_00

Regression

No, this bug or issue has existed throughout my experience using Warp

Recent working Warp date

No

Additional context

No response

Does this block you from using Warp daily?

Yes, this issue prevents me from using Warp daily.

Is this a Warp specific issue? (i.e. does it happen in Terminal, iTerm, Kitty, etc.)

Yes, this I confirmed this only happens in Warp, not other terminals.

Warp Internal (ignore): linear-label:b9d78064-c89e-4973-b153-5178a31ee54e

None

jatindotdev commented 10 months ago

Edit:

This is related to the fish config i have, but this error only happens in warp

alias "+x" "chmod +x"
dannyneira commented 10 months ago

Hey @jatindotdev thanks for letting us know, as a possible workaround you can wrap the alias (or any other code causing issues ), in the conditional below to disable it just for Warp. We'll post any updates on this thread.

# Fish
if test "$TERM_PROGRAM" != "WarpTerminal"
# > What you want to disable here <
  alias "+x" "chmod +x"
end

To anyone else facing this issue, please add a 👍 to the original post at the top or comment with your details, and subscribe if you'd like to be notified.