warpdotdev / Warp

Warp is a modern, Rust-based terminal with AI built in so you and your team can build great software, faster.
https://warp.dev
Other
21.04k stars 360 forks source link

(Regression) Warp duplicating custom prompt on latest stable #4057

Closed GregoryConrad closed 8 months ago

GregoryConrad commented 8 months ago

Discord username (optional)

No response

Describe the bug

Just updated to the latest stable, and my shell prompt is getting duplicated several times. This did not happen on the previous stable release.

Side question: how can I rollback my warp client to the previous release?

To reproduce

Use a custom prompt in zsh. At least, mine is causing this duplication issue: https://github.com/GregoryConrad/dotfiles/blob/master/.zshrc

Expected behavior

Prompt not being duplicated as it is shown below.

Screenshots

Screenshot 2024-01-11 at 6 41 34 PM

Operating system

MacOS

Operating system and version

macOS 14.2.1

Shell Version

zsh 5.9 (x86_64-apple-darwin23.0)

Current Warp version

v0.2024.01.09.08.02.stable_01

Regression

Yes, this bug started recently or with an X Warp version

Recent working Warp date

Few days ago, before this most recent update

Additional context

No response

Does this block you from using Warp daily?

No

Is this a Warp specific issue? (i.e. does it happen in Terminal, iTerm, Kitty, etc.)

Yes, this I confirmed this only happens in Warp, not other terminals.

Warp Internal (ignore): linear-label:b9d78064-c89e-4973-b153-5178a31ee54e

None

pereirinha commented 8 months ago

Same here.

luis-neira commented 8 months ago

Same. Any recommendations.

verheyenkoen commented 8 months ago

Same issue since latest update.

jeffstedt commented 8 months ago

Same here

kcculhwch commented 8 months ago

Seeing the same thing on my terminal too. (using oh-my-posh) -- added comment-- I notice that the right hand features of oh-my-posh appear only once., and they appear to be spaced over to the end of the line as if there were no duplicated left hand prompts (ie it inserted the correct number of empty spaces for the prompt to have occurred once, instead of 4 times):

Screenshot 2024-01-12 at 8 03 37 AM

-- added comment-- echo $PS1 in warp yields this now:

%{%{%}  %{%}%{%}%{%}%{%}%{%} ~ %{%}%{%} %{%}%{%}%{%}%{%}%{%} default%{%}%{%} %{%}%{%}%{%}%{%}  %{%}%{%}%{%}%{%}%{%} ~ %{%}%{%} %{%}%{%}%{%}%{%}%{%} default%{%}%{%} %{%}%{%}%{%}%{%}  %{%}%{%}%{%}%{%}%{%} ~ %{%}%{%} %{%}%{%}%{%}%{%}%{%} default%{%}%{%} %{%}%{%}%{%}%{%}  %{%}%{%}%{%}%{%}%{%} ~ %{%}%{%} %{%}%{%}%{%}%{%}%{%} default%{%}%{%} %{%}%{%}%{%}%} 

while the same command in iterm yields:

%{%}  %{%}%{%}%{%}%{%}%{%} ~ %{%}%{%} %{%}%{%}%{%}%{%}%{%} default%{%}%{%} %{%}%{%}
dannyneira commented 8 months ago

Hey folks, we're aware of this issue and are working to revert the change that may have caused this. It primarily looks to be affecting custom prompts, not the Warp prompt.

We'll post any further updates on this thread.

dannyneira commented 8 months ago

hey Folks, Warp version v0.2024.01.09.08.02.stable_02 has been released which reverts the change that caused this regression. Please update and stay tuned for the fix.

verheyenkoen commented 8 months ago

@dannyneira Brilliant! Thanks.

yousecjoe commented 8 months ago

I updated it to v0.2024.01.09.08.02.stable_02, and the issue is fixed. Thanks for fixing it so fast!

dannyneira commented 8 months ago

Nice! closing as resolved