warpdotdev / Warp

Warp is a modern, Rust-based terminal with AI built in so you and your team can build great software, faster.
https://warp.dev
Other
21.11k stars 361 forks source link

linux: fish fzf shortcut keys are not triggered #4125

Open yulrizka opened 8 months ago

yulrizka commented 8 months ago

Discord username (optional)

No response

Describe the bug

While using fzf.fish. all the triggered shortcut are not appearing

To reproduce

  1. Use fish shell
  2. install fish plugin https://github.com/PatrickF1/fzf.fish
  3. press ctrl+alt+f for displaying file completion

Expected behavior

file should appear like in other terminal

Screenshots

example of same command running on other terminal image

Operating system

Linux

Operating system and version

39.0.0

Shell Version

fish 3.7.0

Current Warp version

v0.2024.01.30.16.52.stable_00

Regression

No, this bug or issue has existed throughout my experience using Warp

Recent working Warp date

No response

Additional context

executing this on warp, give this message

16:10:00 [INFO] dispatching typed action: UnhandledModifierKey("ctrl-alt-f")
16:10:00 [INFO] dispatching typed action: UnhandledModifierKey("ctrl-alt-f")
16:10:01 [INFO] dispatching typed action: UnhandledModifierKey("ctrl-alt-f")
16:10:01 [INFO] dispatching typed action: UnhandledModifierKey("ctrl-alt-f")

I'm using completion alot.

Does this block you from using Warp daily?

Yes, this issue prevents me from using Warp daily.

Is this a Warp specific issue? (i.e. does it happen in Terminal, iTerm, Kitty, etc.)

Yes, this I confirmed this only happens in Warp, not other terminals.

Warp Internal (ignore): linear-label:b9d78064-c89e-4973-b153-5178a31ee54e

None

cmjoseph07 commented 7 months ago

I am running into this exact same issue and it preventing me from using Warp as a daily driver as well.

drewlustro commented 4 weeks ago

I'm seeing this too. I try to use fzf.fish's command history search, aka "reverse-i-search", which is bound to ^R. It also does not work.

I suspect it's because ^R is already reserved by Warp. Unfortunately, attempt to rebind this command to something else like ^⇧R does not help. Warp seems to swallow the keystroke.

Capture 2024-09-06 - 002049

yulrizka commented 3 weeks ago

Ineed. from the log above, seems like the issue is that unhandled modifier key is not forwarded to the shell.