search

warpdotdev / Warp

Warp is a modern, Rust-based terminal with AI built in so you and your team can build great software, faster.
https://warp.dev
Other
21.33k stars 372 forks source link

I can't set a default shell just for Warp #4351

Closed lucasvsr closed 1 month ago

lucasvsr commented 8 months ago

Discord username (optional)

No response

Describe the bug

When I try to change the default shell in the option available in Settings > Features > Session > Startup shell for new sessions the configuration I made is not persisted in the file ~/.config/warp-terminal/user_preferences.json and when I reopen the application, the default shell has not been changed.

Are there any limitations? It seems like a bug to me since I have the option to use bash and when I select this option it changes the file ~/.config/warp-terminal/user_preferences.json

I attach a video showing the bug.

To reproduce

  1. Change the default shell in Settings > Features > Session > Startup shell for new sessions
  2. Restart the application.
  3. Check if the file ~/.config/warp-terminal/user_preferences.json has been changed and the default shell has changed.

Expected behavior

No response

Screenshots

No response

Operating system

Linux

Operating system and version

Fedora Linux 39.20240224.0 (Silverblue) x86_64

Shell Version

bash 5.2.26

Current Warp version

v0.2024.02.20.08.01.stable_02

Regression

No, this bug or issue has existed throughout my experience using Warp

Recent working Warp date

No response

Additional context

No response

Does this block you from using Warp daily?

Yes, this issue prevents me from using Warp daily.

Is this a Warp specific issue? (i.e. does it happen in Terminal, iTerm, Kitty, etc.)

Yes, this I confirmed this only happens in Warp, not other terminals.

Warp Internal (ignore): linear-label:b9d78064-c89e-4973-b153-5178a31ee54e

None

dannyneira commented 8 months ago

hey @lucasvsr Warp only supports bash,zsh, or fish for default shells. Since boxkit isn't a supported shell, Warp defaults to bash on Linux (and zsh on macOS). https://docs.warp.dev/getting-started/using-warp-with-shells

Hope this helps! Please let me know of any issues with switching your default shell.

lucasvsr commented 8 months ago

OK I understand! And in fact, when I pointed it to the fish shell installed in my environment it worked. I use a distrobox as a shell, thus keeping my entire environment in a container, and boxkit is a script I use to access it.

I understand how it works, but it would be cool if they allowed this integration with containers like those from distrobox or if we used any binary instead of just bash/zsh/fish.

Your idea is sensational and the implementation is great. Good job guys! If you can tell me where I can add the suggestion I made above or convert this issue into a suggestion, I would appreciate it.

lucasvsr commented 1 month ago

Guys, I managed to make it work. Thanks!