warpdotdev / Warp

Warp is a modern, Rust-based terminal with AI built in so you and your team can build great software, faster.
https://warp.dev
Other
21.27k stars 370 forks source link

Colors in terminal #4565

Closed iwex closed 5 months ago

iwex commented 7 months ago

Discord username (optional)

No response

Describe the bug

I've converted this theme https://github.com/ahmadawais/Shades-of-Purple-iTerm2/blob/master/shades-of-purple.itermcolors with https://terminal-themes.com/create-theme.

And I can't get the same bright colors. Even white is not white. Compared to iterm2 it is a bit darker

CleanShot 2024-03-15 at 10 48 27

Here is the code for it

accent: "#fad000"
background: "#1e1d40"
foreground: "#feffff"
details: "darker"
terminal_colors:
  normal:
    black: "#000000"
    red: "#d90429"
    green: "#3ad900"
    yellow: "#ffe700"
    blue: "#6943ff"
    magenta: "#ff2b70"
    cyan: "#00c5c7"
    white: "#c7c7c7"
  bright:
    black: "#676767"
    red: "#f9291b"
    green: "#42d425"
    yellow: "#f1d000"
    blue: "#6871ff"
    magenta: "#ff76ff"
    cyan: "#79e7fa"
    white: "#feffff"

To reproduce

I've converted this theme https://github.com/ahmadawais/Shades-of-Purple-iTerm2/blob/master/shades-of-purple.itermcolors with https://terminal-themes.com/create-theme and installed to Warp

Expected behavior

Bright colors

Screenshots

CleanShot 2024-03-15 at 10 52 12

Operating system

MacOS

Operating system and version

MacOS 14.4

Shell Version

zsh 5.9

Current Warp version

v0.2024.03.12.08.02.stable_01

Regression

No, this bug or issue has existed throughout my experience using Warp

Recent working Warp date

No response

Additional context

No response

Does this block you from using Warp daily?

Yes, this issue prevents me from using Warp daily.

Is this a Warp specific issue? (i.e. does it happen in Terminal, iTerm, Kitty, etc.)

Yes, this I confirmed this only happens in Warp, not other terminals.

Warp Internal (ignore): linear-label:b9d78064-c89e-4973-b153-5178a31ee54e

None

dannyneira commented 7 months ago

Hi @iwex sorry about this, Warp does take into account the details "darker" "lighter" and adds a filter over colors based on that so try swaping to the latter and see if that helps with getting a brighter white. Also make sure you have the same font configured as the font may also be affecting the look of it.

Hope this helps!

iwex commented 7 months ago

@dannyneira I copied old theme to shades-lighter and replaces darker with lighter, but as you can see - no changes.

https://github.com/warpdotdev/Warp/assets/4510068/8815780c-4f97-4895-83dd-727604fccc50

dannyneira commented 7 months ago

Thanks for letting us know. We're looking into the dimming that's being placed on text and will post updates on this thread

david-zamora-minderest commented 7 months ago

I have found that in comparison with other terminals, Warp paints what seems to be the blue color as purple. I use Warp with ZSH and starship with a very clean and simple configuration. I tried Ubuntu terminal and Tillix, both paint it dark blue, nor purple. Tillix / Terminal image

Warp Image image

jennso commented 6 months ago

Having the same issue here I copied my iterm colors theme, I believe the colors are corrrect but seems like warp add a dark overlay or dimms the colors down, maybe is a configurable setting that affects all themes? here is the example.

image

azat-io commented 5 months ago

I have the same problem. All the colors seem dull. My theme:

accent: "#fabd2f"
background: "#141718"
foreground: "#fbf1c7"
terminal_colors:
  bright:
    black: "#1d2021"
    blue: "#83a598"
    cyan: "#8ec07c"
    green: "#b8bb26"
    magenta: "#d3869b"
    red: "#fb4934"
    white: "#fbf1c7"
    yellow: "#fabd2f"
  normal:
    black: "#1d2021"
    blue: "#458588"
    cyan: "#8ec07c"
    green: "#b8bb26"
    magenta: "#d3869b"
    red: "#fb4934"
    white: "#fbf1c7"
    yellow: "#fabd2f"
dannyneira commented 5 months ago

Hi Folks, this is being worked on and should be released soon. Its something we're tracking here and have recently posted an update. https://github.com/warpdotdev/warp/issues/362#issuecomment-2123400075

dannyneira commented 5 months ago

Duplicate of https://github.com/warpdotdev/warp/issues/362

dannyneira commented 4 months ago

Hey Folks, As of the latest release, Warp now renders terminal text ANSI colors as specified by the theme without any dimming.

Please update and let us know if the issue persists.

jennso commented 4 months ago

I updated and it was working, but this morning I relaunched and it's back to dimmed colors, the version I have is v0.2024.05.28.08.02.stable_00

jennso commented 4 months ago

I just realized is not a color thing but a DPI thing, on my 4k screen the colors look slighlty diferent but on my 1440p they look the same.

tariksetia commented 3 months ago

@dannyneira Do I need to change any settings for fixing colors?

version: v0.2024.06.25.08.02.stable_01

Please take a look at image below.(left one is warp and right one is hyper). There is clearly a color difference. I am not sure if it is a bug or it is behaving as intended 😅

image image

dannyneira commented 3 months ago

@iwex afaik Warp now renders terminal text ANSI colors as specified by the theme without any dimming. Even if you're using the same theme the presentation of colors may be different than other terminals (based on how they render the theme ANSI colors). Please learn more about how Warp renders text here.