warpdotdev / Warp

Warp is a modern, Rust-based terminal with AI built in so you and your team can build great software, faster.
https://warp.dev
Other
21.47k stars 376 forks source link

You completely broke "Copy On Select" and now it's unusable #4580

Open WadeLewis opened 8 months ago

WadeLewis commented 8 months ago

Discord username (optional)

No response

Describe the bug

latest change: '"Copy on Select" now works within alt-screens'

Yeah, now whenever I highlight anything on my CLI (like, highlight section to paste what is in my clipboard, so I can overwrite the highlighted section with the thing that I had copied), warp will overwrite my clipboard right before i paste(!)

This is incredibly stupid, can't believe you just broke the entire feature like that. Now highlight-pasting anything at the CLI is entirely busted.

WTF?

Here's a simple, stupid example of why I hate this.

kubectly get deploy

(you get several results, e.g. my-deploy. dev-deploy-gateway, etc. Copy one of them to be put into another command below) kubectl describe deploy my-deploy | grep -E 'mage'

Up arrow to get to previous command, attempt to highlight my-deploy and paste in the recently copied dev-deploy-gateway

This is the command I intend to run, by pasting dev-deploy-gateway over my-deploy kubectl describe deploy dev-deploy-gateway | grep -E 'mage'

But when I go to highlight the previous statement and hit paste, it just overwrites my clipboard. So I just highlight (unintentionally copy the highlighted), and paste over the highlight. This is NOT the intention.

I prefer the old functionality, where if Im using my mouse to highlight some crap from the terminal output from elsewhere, it will overwrite the clipboard, but if I just use the shift key to rewrite text on the CLI, it shouldn't overwrite my entire clipboard

To reproduce

turn on the feature, and literally highlight a word in the CLI to paste over while you're typing. Instead of pasting what's in your clipboard, you just paste what you highlighted, because the highlight act overwrites the clipboard buffer. Incredibly frustrating/stupid addition to an otherwise fine feature.

Expected behavior

when i am typing and i control + shift + arrow key to highlight the word next to me, it should NOT copy to clipboard.

this wasn't a problem when I left on Friday, and now it is. Extremely frustrating change of the functionality to make it from semi useful (highlight output from a terminal and auto copy) to extremely not useful (your clipboard buffer is going to be pillaged if you use highlight-rewrite workflows on the CLI)

Screenshots

No response

Operating system

MacOS

Operating system and version

13.6.3

Shell Version

No response

Current Warp version

v0.2024.03.12.08.02.stable_01

Regression

No, this bug or issue has existed throughout my experience using Warp

Recent working Warp date

No response

Additional context

No response

Does this block you from using Warp daily?

No

Is this a Warp specific issue? (i.e. does it happen in Terminal, iTerm, Kitty, etc.)

Yes, this I confirmed this only happens in Warp, not other terminals.

Warp Internal (ignore): linear-label:b9d78064-c89e-4973-b153-5178a31ee54e

None

gorgos commented 8 months ago

see https://github.com/warpdotdev/Warp/issues/4566, you need to turn off 'Copy on Select' in the settings, but looks like a recent update changed this setting for people automatically