search

warpdotdev / Warp

Warp is a modern, Rust-based terminal with AI built in so you and your team can build great software, faster.
https://warp.dev
Other
20.99k stars 359 forks source link

Performance slowdown lately #4786

Closed lucianthorr closed 2 months ago

lucianthorr commented 5 months ago

Discord username (optional)

No response

Describe the bug

I habitually keep my Warp terminal up-to-date and I feel like within the last two updates, like in the last week or so, it's having frequent momentary freezes. Typing commands can have a half second lag before showing up in the UI, Cmd+Q doesn't quit and if I go to the title bar > File > Quit is disabled. It seems to be caused by event and then things start slowing down or freezing and then I restart and it's fine. It's very unlike Warp in the past though, which has always been consistently reactive.

To reproduce

I'm still working on finding a reproducible cause. My only hint is that maybe it starts happening after an ssh session times out or fails. But even in this case, when the slowdown happens, it effects all tabs, not just the one handling ssh.

Expected behavior

The usual snappy response of Warp.

Screenshots

No response

Operating system

MacOS

Operating system and version

Ventura

Shell Version

zsh 5.9 (x86_64-apple-darwin22.0)

Current Warp version

v0.2024.04.16.08.02.stable_00

Regression

Yes, this bug started recently or with an X Warp version

Recent working Warp date

No response

Additional context

No response

Does this block you from using Warp daily?

No

Is this a Warp specific issue? (i.e. does it happen in Terminal, iTerm, Kitty, etc.)

Yes, this I confirmed this only happens in Warp, not other terminals.

Warp Internal (ignore): linear-label:b9d78064-c89e-4973-b153-5178a31ee54e

None

t-var-s commented 5 months ago

I seem to be having the same issue recently with Warp becoming unresponsive. Seems to happen when the terminal has been left open and not used for a while. Or it may be an issue with how updates are being received, this bug does not happen every day.

I'm currently on Sonoma 14.4.1 and using zsh 5.9 Warp is on v0.2024.04.16.08.02.stable_00

alokedesai commented 5 months ago

@lucianthorr @t-var-s Thanks for filing and sorry for the issues here--this definitely isn't how Warp should work.

Do the lags occur only when typing into the input editor or do they occur when using any part of the app? Could you share a video next time you see the behavior?

t-var-s commented 5 months ago

Do the lags occur only when typing into the input editor or do they occur when using any part of the app? Could you share a video next time you see the behavior?

I've noticed it as I start to type into the prompt. Warp becomes unresponsive and the option to quit becomes disabled. Since I usually don't have the time to wait, I have to force kill the process and run Warp again.

BTW, it might also be relevant that I always run Warp full screen on macOS. I'll try to record a video if the bug happens again. Let's see if it coincides with some update dropping.

alokedesai commented 5 months ago

Thanks! A video here next time you see this would be really useful so we can debug further.

t-var-s commented 4 months ago

At least in my case, it does seem related to getting an update. After Warp updates, instead of showing the usual What's New panel, the terminal stops at loading the prompt and the option to quit is disabled. Here's a video:

https://github.com/warpdotdev/Warp/assets/6660327/fd983995-522d-48a8-a4cd-b67e484716d8

If I force quit and restart Warp, it now behaves normally and shows what's new.

lucianthorr commented 4 months ago

Apologies for the silence here. I haven't needed SSH much this week so I haven't had the opportunity to test. I can confirm that the disabled Quit shown above was present during my freezes also though. Thanks @t-var-s

TowhidKashem commented 4 months ago

I came here to look up if anyone else is having issues as of late too! In the past I never dif but as of the last few weeks warp is freezing, the fans are going off and if I open activity monitor it appears at the top of the list. Mind you when this happens I am not even doing anything in the terminal most of the time, it just happened to be open as it usually is. I've had to quit and go back to using the regular terminal which sucks after having used WARP :(

I suspect there is a memory leak somewhere that got merged with a recent commit.

P.S. this is on a intel macbook with specs:

2.6 GHz 6-Core Intel Core i7 32 GB DDR4 RAM

alokedesai commented 4 months ago

@t-var-s Just to confirm, you don't see a beach ball when this happens, right?

When you get into the state where you can't quit Warp and the prompt is stuck at "loading prompt", does every session have the same issue or is it only specific sessions? Would be able to share your Warp logs with us so we can debug further?

alokedesai commented 4 months ago

@TowhidKashem When you say "Warp is freezing" are you seeing the same issue @t-var-s mentions above or is Warp completely unresponsive for you? Could you share a video of what you're seeing?

TowhidKashem commented 4 months ago

@TowhidKashem When you say "Warp is freezing" are you seeing the same issue @t-var-s mentions above or is Warp completely unresponsive for you? Could you share a video of what you're seeing?

I just remember it being unresponsive and having to force quit it from activity monitor. If it happens again I'll try to take a video.

lucianthorr commented 4 months ago

Was able to capture the freezing. I updated today while ssh'd in and it handled the connection during the upgrade but a few minutes later, I was starting to see the slowdown described above. You can see it effects both the ssh'd shell tab and the local tab. If you have audio, you can hear that the text that's showing up is well behind when it's being typed. Also, Quit is disabled.

https://github.com/warpdotdev/Warp/assets/5907505/cb60405b-ed01-4731-839d-52c56470ac4d

t-var-s commented 4 months ago

Just happened again with the latest update to v0.2024.04.30.08.02.stable_01

@t-var-s Just to confirm, you don't see a beach ball when this happens, right?

Right, dont' think I've ever seen a beach ball on warp.

When you get into the state where you can't quit Warp and the prompt is stuck at "loading prompt", does every session have the same issue or is it only specific sessions?

Every session gets stuck. Here are the logs from the latest frozen state:

2024-05-04T18:38:08Z [INFO] Starting shell /bin/zsh
2024-05-04T18:38:08Z [INFO] Successfully spawned tty with pid: 94194
2024-05-04T18:38:08Z [INFO] Successfully spawned child zsh process with pid 94194
2024-05-04T18:38:08Z [INFO] dispatching global action for workspace:save_app
2024-05-04T18:38:08Z [INFO] dispatching global action for workspace:save_app
2024-05-04T18:38:08Z [WARN] Tried to update block filter query without active_filter_editor_block_index set
2024-05-04T18:38:08Z [WARN] Tried to render share modal without a model
2024-05-04T18:38:08Z [WARN] redraw_frame was called 2 times before the frame was drawn
2024-05-04T18:38:11Z [WARN] redraw_frame was called 3 times before the frame was drawn
2024-05-04T18:38:20Z [WARN] redraw_frame was called 2 times before the frame was drawn
2024-05-04T18:38:20Z [WARN] redraw_frame was called 4 times before the frame was drawn
2024-05-04T18:38:30Z [INFO] dispatching global action for root_view:update_quake_mode_state
t-var-s commented 4 months ago

For this latest update, I uninstalled warp, kept its files and downloaded it again from the website. Let's see if the issue persists now.

t-var-s commented 4 months ago

Let's see if the issue persists now.

Still happening when updating to v0.2024.05.14.08.01.stable_04

Yoni-apex commented 3 months ago

I was looking for issues to find something similar and this is it. I have the same issue:

When I update, nothing happens. The settings show "Updating...". I have to Force Quit and when I open it again, it shows the "What's New". Regular quit is not working either.

System is: Macbook Pro 14-inch, Nov 2023 M3 Pro Sonoma 14.1

Warp is now: v0.2024.05.21.16.09.stable_02

alokedesai commented 3 months ago

@Yoni-apex @t-var-s Does cmd-q work to quit or is that also broken?

alokedesai commented 3 months ago

@Yoni-apex Do you also see the performance issues that the author of this issue is experiencing?

Yoni-apex commented 3 months ago

Yes, after trying to update only.

Yoni-apex commented 3 months ago

@Yoni-apex @t-var-s Does cmd-q work to quit or is that also broken?

Broken, Force Quit only...

alokedesai commented 3 months ago

What version of MacOs are you using? Do you have any security software installed on your machine, by chance?

lucianthorr commented 3 months ago

Ventura 13.5 here. No third party security software. FileVault not enabled either.

Yoni-apex commented 3 months ago

What version of MacOs are you using? Do you have any security software installed on your machine, by chance?

Sonoma 14.1 and no security software. Without FileVault either. And used to work before. Maybe before the next update we could do something to get precise logs of the update?

Let me know how I can help :)

t-var-s commented 3 months ago

@Yoni-apex @t-var-s Does cmd-q work to quit or is that also broken?

The issue persists when updating to v0.2024.05.21.16.09.stable_02 Cmd-q is also broken.

alokedesai commented 3 months ago

Hi all, thanks for your patience here. We're still trying to better understand why this is happening.

I'm looking for someone who would be willing to spend ~30 minutes in a Zoom call with me to debug this further. If you're interested (and based in a time zone that has overlap with the US East Coast) please email me at aloke@warp.dev. We would send you Warp swag as a thank you for your time.

alokedesai commented 3 months ago

Just an update here. This happens when you try to update when Warp is fullscreen. I recently merged a fix for this and it should be available next week. Thanks again for your patience here.

t-var-s commented 3 months ago

This happens when you try to update when Warp is fullscreen.

Can confirm that this should be the cause 👍 I always have Warp in fullscreen.

t-var-s commented 2 months ago

Have the fix 👍 Warp in fullscreen now updates normally.

alokedesai commented 2 months ago

Great to hear. Thanks for everyone’s patience here. Going to go ahead and close this out.