warpdotdev / Warp

Warp is a modern, Rust-based terminal with AI built in so you and your team can build great software, faster.
https://warp.dev
Other
20.18k stars 332 forks source link

ssh autocomplete for fish shell no longer works #4961

Open ElijahLynn opened 1 month ago

ElijahLynn commented 1 month ago

Dupe Check

Describe the bug

Recently SSH autocompletion with my fish shell worked fine, something broke it in the past week or so. This is mainly a rubber ducking thread and I'll post my results here. This might be a fish issue, might be a warp issue. But I do know that if I open a non-Warp shell then SSH autocompletion works as expected.

To reproduce

type ssh then . Nothing happens.

Expected behavior

List of hosts in ~/.ssh/config to return.

Screenshots

No response

Operating system

MacOS

Operating system and version

14.5 (23F79)

Shell Version

fish, version 3.7.1

Current Warp version

v0.2024.05.14.08.01.stable_04

Regression

Yes, this bug started recently or with an X Warp version

Recent working Warp date

No response

Additional context

No response

Does this block you from using Warp daily?

No

Is this a Warp specific issue? (i.e. does it happen in Terminal, iTerm, Kitty, etc.)

Yes, this I confirmed this only happens in Warp, not other terminals.

Warp Internal (ignore): linear-label:b9d78064-c89e-4973-b153-5178a31ee54e

None

dannyneira commented 4 weeks ago

Warp has an SSH Wrapper that enables features (like the blocks, prompt, completions, etc.) on remote machines requiring the default prompt on the remote machine to be either bash or zsh.

As a workaround you can add command ssh to your Settings > Subshells > Added commands menu, then run command ssh <user@server> to connect to remote session, this will attempt to enable Warp features as a subshell.

You can also try disabling the SSH Wrapper by navigating to Settings > Features. Blocks will stop working but with it disabling, SSH should work as normal.

Related docs: https://docs.warp.dev/features/ssh https://docs.warp.dev/features/subshells

If those don't work, please let us know.

ElijahLynn commented 4 weeks ago

Thanks, I should have noted that I have already disabled the SSH wrapper when experiencing this issue.

edit: just confirmed that is still the case (and it didn't get re-enabled on an update or another way etc.)

image

edit2: I'll try to add the subshell commands to I can re-enable the wrapper. This was my blocker:

dannyneira commented 4 weeks ago

yes the subshell method is a workaround to use fish shell on remote machines. Let me know if that helped