warpdotdev / Warp

Warp is a modern, Rust-based terminal with AI built in so you and your team can build great software, faster.
https://warp.dev
Other
21.53k stars 377 forks source link

Add option to change cursor foreground colour #5269

Open joshdales opened 3 months ago

joshdales commented 3 months ago

Dupe Check

Describe the solution you'd like?

There is now an option to change the cursor colour for a theme. However, if I use the block cursor or Vim keybindings when I'm in visual mode depending on what I change that colour to the text can become invisible. If the text is dark and the cursor is light (or visa versa) then everything works great. But because the colour of the text doesn't seem to change when you move over the letter it can result in some bad contrast.

It would be great if I could specify a foreground colour for the cursor as well as the background.

Is your feature request related to a problem? Please describe.

No response

Additional context

Example of when the colours can all go a bit wonky:

Screenshot 2024-08-31 at 3 02 05 PM Screenshot 2024-08-31 at 3 02 15 PM

How important is this feature to you?

2

Warp Internal (ignore) - linear-label:39cc6478-1249-4ee7-950b-c428edfeecd1

None

dannyneira commented 2 months ago

Thanks for this feature request @joshdales I see how the cursor color may make the text harder to see in those cases. I'll let the team know and we'll post any updates on this thread.

To anyone else interested in this feature, please add a 👍 to the original post at the top to signal that you want this feature, and subscribe if you'd like to be notified.

dansalvato commented 5 days ago

Related: #3917 and #1975

The Vim/Neovim cursor rendering issues are holding me back from switching to Warp. I think because issue reports typically come from already-committed users, the importance of an issue like this is drastically underestimated. There must be thousands of users who try out Warp and ditch it as soon as they notice rendering issues in Vim/Neovim. It's where some of us spend 90% of our time in the terminal, so the experience can't really be compromised.