warpdotdev / Warp

Warp is a modern, Rust-based terminal with AI built in so you and your team can build great software, faster.
https://warp.dev
Other
21.26k stars 369 forks source link

Powerlevel10k looking poorly formatted (with correct fonts) #5394

Open sam-david opened 4 days ago

sam-david commented 4 days ago

Dupe Check

Describe the bug

I'm using powerlevel10k zsh and no matter what font I choose (Meslo NF, Nerd Font, etc..) the formatting is always off. The closest I could get is this screenshot Screenshot 2024-10-18 at 9 53 46 AM Screenshot 2024-10-18 at 9 58 41 AM

For reference here is what it looks like in iterm Screenshot 2024-10-18 at 9 56 47 AM

Strangely enough I have an old version of powerlevel installed on another computer and the formatting is fine when I changed to nerd font.

To reproduce

To reproduce install powerlevel 10k theme https://github.com/romkatv/powerlevel10k

Expected behavior

No response

Screenshots

No response

Operating system

MacOS

Operating system and version

15.0.1 (24A348)

Shell Version

No response

Current Warp version

No response

Regression

No, this bug or issue has existed throughout my experience using Warp

Recent working Warp date

No response

Additional context

No response

Does this block you from using Warp daily?

No

Is this an issue only in Warp?

Yes, I confirmed that this only happens in Warp, not other terminals.

Warp Internal (ignore): linear-label:b9d78064-c89e-4973-b153-5178a31ee54e

None

vorporeal commented 4 days ago

Hey @sam-david - thanks for the report!

A few quick questions to help us debug:

  1. Is this a regression from a previous version, or are you a new user? (I see you said "No" above but just want to double-check.)
  2. Does it look incorrect in the input and blocks, or only in the settings dialog?
  3. Does it look equally incorrect with other fonts, or just that one?
sam-david commented 4 days ago

Hi @vorporeal Thanks for taking this on. I really would like to use powerlevel10k with warp if possible.

  1. I'm a new user to warp in general so not sure about regression
  2. It looks incorrect in blocks, inputs, and settings. All the same
  3. All fonts look off but some make it work better than others

Here is the best I was able to make it look compared to iterm. Mostly color and the arrow in between look off

Screenshot 2024-10-18 at 3 22 29 PM

Screenshot 2024-10-18 at 3 22 17 PM
vorporeal commented 4 days ago

To fix the arrow color, you can change the value of "Enforce minimum contrast" in "Settings > Appearance" to "Never".

Which version of Warp are you using? We actually just rolled out (in this week's release) some improvements to rendering of fancy prompts that are intended to address these sorts of alignment issues.

sam-david commented 3 days ago

Using the latest update! The enforce minimum contrast setting did help with the arrows but colors are very different from what I'm seeing in iTerm. Is there another setting to adjust? When changing force minimum contrast to never it did make some fonts harder to read.

One example WhatsApp Image 2024-10-19 at 14 21 17 Other example Screenshot 2024-10-19 at 2 21 38 PM

With contrast setting back on Screenshot 2024-10-19 at 2 22 35 PM Screenshot 2024-10-19 at 2 22 12 PM

I'm glad to see your continuous development. I'm definitely sold on warp and am using it across systems now. These issues are minor but I would like to see improvement here or instruction on how I can tweak my settings.

vorporeal commented 1 day ago

Differences in colors could just be due to different theme colors. Command-line applications can either specify a 24-bit RGB color or select use of a "named" color, where the mapping from color name (e.g.: "red" or "blue") to a specific color is determined by the terminal (e.g.: iTerm or Warp).

Warp supports custom themes, though we don't yet support customizing theme colors in the UI, only via a theme file. There are instructions here: https://docs.warp.dev/appearance/custom-themes

You could try configuring a theme that matches the colors you have configured in iTerm; if you do, let me know if you're still seeing differences (with minimal contrast enforcement disabled).