warpdotdev / Warp

Warp is a modern, Rust-based terminal with AI built in so you and your team can build great software, faster.
https://warp.dev
Other
21.5k stars 376 forks source link

Fish not working #5444

Open zany130 opened 3 weeks ago

zany130 commented 3 weeks ago

Dupe Check

Describe the bug

when using fish as the startup shell warp never fully loads it getting stuck on a "starting fish" prompt

To reproduce

  1. set fish as the default shell in Settings -> Features startup shell for new sessions
  2. relaunch warp
  3. notice warp never fully loads

Expected behavior

Warp loads and brings me into a fish prompt

Screenshots

image

image

Operating system

Linux

Operating system and version

Bazzite 41

Shell Version

fish 3.7.0

Current Warp version

v0.2024.10.29.08.02.stable_02

Regression

No, this bug or issue has existed throughout my experience using Warp

Recent working Warp date

No response

Additional context

Tested with a stock fish config. By moving my ~/.config/fish/ and ~/.local/fish/ folders to another drive

also nothing in /etc/fish/

tree /etc/fish
/etc/fish
├── completions
├── conf.d
├── config.fish
└── functions

4 directories, 1 file
cat /etc/fish/*
cat: /etc/fish/completions: Is a directory
cat: /etc/fish/conf.d: Is a directory
# Put system-wide fish configuration entries here
# or in .fish files in conf.d/
# Files in conf.d can be overridden by the user
# by files with the same name in $XDG_CONFIG_HOME/fish/conf.d

# This file is run by all fish instances.
# To include configuration only for login shells, use
# if status is-login
#    ...
# end
# To include configuration only for interactive shells, use
# if status is-interactive
#   ...
# end
cat: /etc/fish/functions: Is a directory

Does this block you from using Warp daily?

Yes, this issue prevents me from using Warp daily.

Is this an issue only in Warp?

Yes, I confirmed that this only happens in Warp, not other terminals.

Warp Internal (ignore): linear-label:b9d78064-c89e-4973-b153-5178a31ee54e

None

Advait-M commented 3 weeks ago

Hey @zany130 - to confirm, you're seeing this only with fish i.e. zsh/bash is functioning correctly on Bazzite?

zany130 commented 3 weeks ago

yesh bash works fine haven't tried zsh

dannyneira commented 3 weeks ago

@zany130 I'd also check to make sure your fish binary (run which -a fish), is set in Warp > Settings > Features > Startup shell for new session > Custom. That may help if Bazzite has it in a non-standard location.

zany130 commented 3 weeks ago

image its in /usr/bin/fish

dannyneira commented 3 weeks ago

Oh i see, it looks like you're using a custom prompt. Please make sure it's supported on our list. https://docs.warp.dev/appearance/prompt#custom-prompt-compatibility-table

Currently on fish, Tide and Oh-My-Fish aren't afaik. Which prompt are you using?

zany130 commented 3 weeks ago

Well in the screenshot, i still have my fish configs but I can move them out so I use default settings and I still have the issue

image

zany130 commented 2 weeks ago

Same thing happens on a fresh install of bazzite

Fish works fine on the default terminal