warpdotdev / Warp

Warp is a modern, Rust-based terminal with AI built in so you and your team can build great software, faster.
https://warp.dev
Other
21.43k stars 374 forks source link

Set -e causes warp to exit. #5456

Open prsabahrami opened 1 week ago

prsabahrami commented 1 week ago

Dupe Check

Describe the bug

Warp terminal instantly exixts upon running the set -e command. I have tried running the command on other terminals and it seems to be working. I also tried the command on Warp on another device and the issue persisted.

To reproduce

Type set -e in the terminal.

Expected behavior

Stay in the shell and modify the shell behaviour based on the options given to the set command.

Screenshots

No response

Operating system

MacOS

Operating system and version

MacOS 14.6.1

Shell Version

zsh 5.9

Current Warp version

v0.2024.10.29.08.02.stable_02

Regression

No, this bug or issue has existed throughout my experience using Warp

Recent working Warp date

No response

Additional context

No response

Does this block you from using Warp daily?

No

Is this an issue only in Warp?

Yes, I confirmed that this only happens in Warp, not other terminals.

Warp Internal (ignore): linear-label:b9d78064-c89e-4973-b153-5178a31ee54e

None

dannyneira commented 1 week ago

Hi @prsabahrami Sorry to hear about this. I'm not seeing the same in my version of Warp. It looks like you're on the latest version of Warp, is there any chance you can share your ~/.zshrc file (make sure to remove any personal info)? This may help us with reproducing the issue. If not can you please provide a copy of your logs (these don't include any input/output). https://docs.warp.dev/help/sending-us-feedback#gathering-warp-logs

vorporeal commented 5 days ago

@prsabahrami I'm guessing some command that Warp is running to compute the prompt is producing an error, and while we handle the error cleanly, set -e is still detecting it and causing the shell process to terminate. We can look into which command is failing and adjust its execution so set -e doesn't pick up on it.

prsabahrami commented 4 days ago

Hi @vorporeal @dannyneira. Sorry for the delay. Please find the logs attached. warp-logs.zip