search

warpdotdev / Warp

Warp is a modern, Rust-based terminal with AI built in so you and your team can build great software, faster.
https://warp.dev
Other
21.4k stars 374 forks source link

Support setting a fallback font #789

Open elviskahoro opened 2 years ago

elviskahoro commented 2 years ago

Describe the solution you'd like?

Support setting a fallback font

Describe the solution you'd like?

Sometimes some fonts do not support some special characters, which will cause display errors. We hope that fallback fonts can be supported.

Is your feature request related to a problem? Please describe.

No response

Additional context

image

CyanChanges commented 8 months ago

Is this feature working in progress? It is opened for about two years.

calops commented 8 months ago

I second this, it would remove the need for patched fonts, and it's a very common feature supported by all modern terminals.

MurtadhaInit commented 8 months ago

It's a shame this is not something being worked on. It's already present in other terminals and I find it quite crucial as it allows the use of non-patched fonts with a specialised nerd font that includes glyphs and icons.

wmcnamee-coreweave commented 6 months ago

Is this being worked on?

remi-gelinas commented 6 months ago

+1 - every modern terminal/editor supports fallbacks, it seems like an odd feature to be missing with how icon-heavy new tooling seems to be

calops commented 6 months ago

I'll go beyond that: the state of the art these days is for the terminal emulator to not only bundle a patched font as a default fallback out of the box, but also handle all box-drawing and powerline symbols natively.

This means actually drawing these symbols perfectly rather than rendering them as font glyphs. This is particularly useful as patched fonts are kind of a hack that isn't working well in plenty of non-default cases (for example, when you change the line spacing), as well as many default ones (the spacing for the fallback font may not be the same as the spacing for the primary font).

hansstimer commented 3 months ago

Would definitely like fallback fonts; much better solution than patching fonts to get NerdFont support.

AurevoirXavier commented 2 months ago

Please place greater emphasis on this and elevate its priority, particularly for a contemporary terminal. For instance, there are numerous symbols in the current Git workflow.

LitoMore commented 1 month ago

I just made an icon font set for brand icons. I'm looking forward to the fallback font so that users can have a chance to test it: