search

warpdotdev / Warp

Warp is a modern, Rust-based terminal with AI built in so you and your team can build great software, faster.
https://warp.dev
Other
21.48k stars 376 forks source link

Use system font (San Francisco for macOS) for window chrome #929

Open bourke opened 2 years ago

bourke commented 2 years ago

Discord username (optional)

No response

Describe the solution you'd like?

It would be great to be able to change or configure the window chrome typeface (which looks like Roboto to me) to something that renders better on lower-DPI settings (such as San Francisco).

Is your feature request related to a problem? Please describe.

I'm on a non-HDPI monitor (I know, I know...) and the rendering for the tabs and status line is just off enough in terms of kerning / weight to be distracting. In the context of many apps I wouldn't be so particular, but I'm in the terminal most of the day and crisp text is important, not just in the terminal itself but its surrounding bits.

The difference may seem subtle, but the screenshots below will hopefully help.

Cheers!

Additional context

image

The crispness (or lack thereof) is similar, but the San Francisco rendering in GitHub Desktop (top) is more readable than that for "Welcome Tips" in Warp.

CleanShot 2022-04-07 at 09 38 21

Here the two typefaces have identical (or nearly so) size and weight, but San Francisco's kerning ("Default Branch") allows for better rendering.

It seems to me that Apple went above and beyond to make sure SF renders well on lower-DPI monitors. I like that Warp is a Mac-native app for a number of reasons; hopefully it will also make swapping typefaces relatively straightforward to accomplish.

elviskahoro commented 2 years ago

Thanks for this suggestion! Will bring this up!

jhaemin commented 1 year ago

Any updates for this?

RokeJulianLockhart commented 9 months ago

https://github.com/warpdotdev/Warp/issues/929#issue-1195316530

@bourke, your title I support — the dynamic usage of the system font — yet you specify that you want to be able to set the font manually to a specific font (San Francisco). These are entirely opposite suggestions, regardless of the mere coincidence that San Francisco happens to correspond to the default macOS font. Consequently, which are you actually suggesting?

bourke commented 9 months ago

@bourke, your title I support — the dynamic usage of the system font — yet you specify that you want to be able to set the font manually to a specific font (San Francisco). These are entirely opposite suggestions, regardless of the mere coincidence that San Francisco happens to correspond to the default macOS font. Consequently, which are you actually suggesting?

Thanks for reviving this issue!

You make a very fair point. My primary concern was / is legibility at small sizes, so please overlook the bit about manual setting.

tomgenoni commented 4 months ago

Supporting the SF font for the settings in the MacOS version, or using Inter universally, would be great.

They each render better than Roboto and would help Warp feel more "Mac-like". Popular dev tooling and tools nearly all use SF font: VSCode, GitHub, GitHub Desktop, Notion (Inter), Netlify, Chrome, Asana, Linear (Inter), Vercel (custom, but same idea), etc.

Warp's main window looks great otherwise!

RokeJulianLockhart commented 4 months ago

https://github.com/warpdotdev/Warp/issues/929#issuecomment-2241911180

@tomgenoni, why do you mention https://fonts.google.com/specimen/Inter? To my knowledge, macOS doesn't define that font as the system one anywhere. Defining static fonts which happen to correspond to the system one is a poor "solution".

This FR is about dynamically adhering to the typeface defined by the OS, somewhat like https://poe.com/s/pFngno2sMw4QJpzQ1tgb explains (as a probably incorrect example) so that users, mostly of non-M1 Macs, who've modified their system partition are able to have that change reflected. Especially usually because it's for the sake of accessibility.

tomgenoni commented 4 months ago

I think you're overcomplicating this. The issue is that the current font looks clunky and could look much better.

@bourke suggested SF, a font better suited for Mac UIs. And I mentioned Inter because it's a very popular font designed specifically for UIs that also works cross-platform (see Notion).

If you're not interested in changing it you can close the issue.

RokeJulianLockhart commented 4 months ago

https://github.com/warpdotdev/Warp/issues/929#issuecomment-2243402256

@tomgenoni, I'm not. The title of this issue requests adherence to the system font preference, which https://github.com/warpdotdev/Warp/issues/929#issuecomment-1960359265 specifically corroberates. Replacing the statically defined typeface of the GUI with another choice is a different issue's purview. You should file one if you want it, but I would suggest that you more broadly file one requesting the ability to change the font of the GUI to an arbitrary system font if you so desire another choice.

tomgenoni commented 4 months ago

A little unsolicited life advice @RokeJulianLockhart... As someone who's been at this for a while, when people are making genuine suggestions for improvements, however imprecise, responding in-kind with patience and grace will get you a long way.

RokeJulianLockhart commented 4 months ago

https://github.com/warpdotdev/Warp/issues/929#issuecomment-2243575358

@tomgenoni, to my knowledge, I am. However, if you've a criticism of my diction, I'll be glad to receive it via any of the myriad social media profiles listed within my profile (at https://dub.sh/jga). Irrespective, do not forget to mark your comment as off-topic, as I shall.