Feature Request: Check state deprecation - Githubissues

warpnet / salt-lint

A command-line utility that checks for best practices in SaltStack.

https://salt-lint.readthedocs.io/en/latest/

MIT License

154 stars 39 forks source link

Feature Request: Check state deprecation #204

Closed roaldnefs closed 3 years ago

roaldnefs commented 3 years ago

Is your feature request related to a problem? Please describe.

It would be nice to notify user about deprecated states in SaltStack.

Describe the solution you'd like

Add the possibility to check for deprecation within used states.

Example(s) of an improperly configured state:

mytestindex:
  elasticsearch_index.present

Example(s) of properly configured state:

mytestindex:
  elasticsearch.index_present

A fix for this issue should (at least):

Notify the user of using a deprecated option
Notify the user since what version the option will be or has been deprecated
A suggestion on what option to replace it with
Contain unit tests for the check

Additional context

This issues is a replacement of:

42
38
39
41
43
44

roaldnefs commented 3 years ago

Note to self and @jbouter: ensure calling saltlint.utils.get_rule_skips_from_text() isn't duplicated for all matchtext() function implementations in new rules.