warpnet / salt-lint

A command-line utility that checks for best practices in SaltStack.
https://salt-lint.readthedocs.io/en/latest/
MIT License
154 stars 39 forks source link

feat: add frequent typo-catching rules #249

Closed jay7x closed 3 years ago

jay7x commented 3 years ago

As Salt is unable to catch some frequent typos there are few checks:

jay7x commented 3 years ago

I put those rules as 'formatting' though we may have 'typos' category maybe..

jbouter commented 3 years ago

:wave: Hi @jay7x! Thanks for your PR! We are currently a bit short on time, but we'll try to look at your code soon.

jay7x commented 3 years ago

Ah! I see.. I missed somehow that BAD_XXX_LINE & GOOD_XXX_LINE are different for every test :-D

jbouter commented 3 years ago

Approved on my end, but I'd like a review by @roaldnefs as well.

jay7x commented 3 years ago

Any chance for this PR to be merged or declined soon? :-D