feat: Add nested dictionary formating check

warpnet / salt-lint

A command-line utility that checks for best practices in SaltStack.

https://salt-lint.readthedocs.io/en/latest/

MIT License

152 stars 39 forks source link

feat: Add nested dictionary formating check #284

Closed sblaisot closed 2 years ago

sblaisot commented 2 years ago

This pull request add a check on proper nested dictionary over-indentation as advised in https://docs.saltproject.io/en/latest/topics/troubleshooting/yaml_idiosyncrasies.html#nested-dictionaries

It adds Rule 219 (which seems to be the first never-used 2xx rule number). Feel free to change rule number if needed.

This fixes #282

jbouter commented 2 years ago

Hi again @sblaisot!

Thanks so much for your PR. Looks like you ticked all the right boxes on your PR as well! We'll try to do a code review as soon as we can, and integrate this new feature into our next release if it passes :-)

sblaisot commented 2 years ago

Thanks for review @matthijswendelaar All comments addressed