search

warpnet / salt-lint

A command-line utility that checks for best practices in SaltStack.
https://salt-lint.readthedocs.io/en/latest/
MIT License
152 stars 39 forks source link

[205] support for non-state jinja files? #309

Open brevilo opened 1 year ago

brevilo commented 1 year ago

Describe the bug Not sure this is a bug. Is salt-lint meant to support linting of jinja template files that are not salt state files, e.g. sourced templated files used in file.managed states, for instance?

To Reproduce Steps to reproduce the behavior:

  1. Run salt-lint on any file named like <name[.jinja|.j2]>
  2. Get result [205] Use ".sls" as a Salt State file extension

Expected behavior Return lint result for jinja template that's not a salt state, not 205.

Desktop (please complete the following information):

Additional context

https://github.com/warpnet/salt-lint/commit/1c2aa5c62ac0eeeaaa6710c0380a92f825351a2a added support to run rules against different file types, namely LANGUAGE_SLS and LANGUAGE_JINJA. However, the file extension rule doesn't specify a languages configuration, but that's presumably on purpose to avoid running into a chicken-and-egg problem.

But, if (pure) jinja linting is meant to be supported, shouldn't the (state file) extension check ignore files that bear a jinja extension only, i.e. without sls anywhere in front of it?

gregorg commented 9 months ago

Any update on this issue ? Cause I had to rename a map.jinja file of an official formulae: https://github.com/saltstack-formulas/dovecot-formula/pull/27 and this is not recommended by Salt.