search

warpstreamlabs / bento

Fancy stream processing made operationally mundane. This repository is a fork of the original project before the license was changed.
https://warpstreamlabs.github.io/bento/
Other
1.06k stars 71 forks source link

properly handle biri.Error #163

Closed arnitolog closed 1 week ago

arnitolog commented 1 week ago

fixes https://github.com/warpstreamlabs/bento/issues/162

arnitolog commented 1 week ago

@gregfurman, I've added an integration test for this case. Please take a look

gregfurman commented 1 week ago

Awesome! Thanks for adding that test.

Your golangci-lint step is failing so just run make fmt && make lint and happy to approve 😄

I added a suggestion that you can also accept that should fix it.

arnitolog commented 1 week ago

@gregfurman , fixed