search

warren-bank / Android-Mock-Location

Android app that mocks the GPS and Network location providers.
GNU General Public License v2.0
141 stars 23 forks source link

App crashes when setting location #2

Closed m0yP closed 3 years ago

m0yP commented 3 years ago

When setting location it just crashes.

Here's the log https://del.dog/nuricuckul

I'm running Android 10 and have enabled Developer Settings and have included the app under the "select mock location app".

warren-bank commented 3 years ago

That security policy was added in Android 9

I need to add a line to AndroidManifest.xml:

  <uses-permission android:name="android.permission.FOREGROUND_SERVICE" />

Thanks for the heads up.. none of my devices are new enough to remind me that I needed to apply updates. Really wish Android devs would stop making breaking changes in userland.

I'll push an update either tonight or early tomorrow.

m0yP commented 3 years ago

Thanks!

warren-bank commented 3 years ago

ok. Please give v2.1.6 a try and let me know if that fixes/prevents the crash.

On an unrelated note.. another thing that I should update is the way the joystick is displayed on API 26+ (Android 8.0). On older versions of Android, the joystick could be long-clicked and dragged to move its position. The layout it used was no-longer allowed and caused the app to crash.. so I made a change that fixes/prevents that crash.. but lost some of its functionality. I think I may investigate that a little tonight..

update:
I was wrong.. the drag functionality actually does still work; it's just really hard to use. It's not activated by long click at all. It basically treats anywhere in its layout that isn't a button as a drag handle: touch, drag, release. The trouble is that the only unused space in the layout are the transparent corners adjacent to the buttons.. which is not intuitive. So, it's an issue of bad UI; easy enough to fix.. just need to think about a better UI solution.

update:
v2.1.7 updates the UI by giving the joystick a drag-handle (at its center).

m0yP commented 3 years ago

Awesome! It works now out of the box. And joystick works ok too. Thanks for the quick response.