Can upgrade Exoplayer version ?

[CMingTseng]

Dear Sir

Exoplayer new release version is 2.1.1

some method change !!

can upgrade ?

i try to upgrade but get crash !!

THX

[warren-bank]

Hi. I'm sorry that the app crashed for you.

This was one of my first Android apps. Having a little more experience with the platform, I'm guessing that the cause for your crash is that:

• the AndroidManifest.xml is requesting READ_EXTERNAL_STORAGE
• this permission is used by MaterialFilePicker
  • their README specifically says that the app using the library is responsible for checking runtime permissions
  • ~I'm pretty sure that I did not~
  • ~I only tested on Android 4.x~
  • this would effect Android 6.0+

When I do fix this issue (and test the app in a newer version of Android).. I'll also be sure to bump the version of ExoPlayer.

• I still can't use the official stable release because the pull-request that adds RTSP support still hasn't been merged
• but the dev branch has made a lot of improvements in the meantime.. which we could benefit from

I'll get around to making these updates in the next few days, and will check back with you here when I have a new release to share.

update:

• I spoke too soon..
  • did a quick grep of the code to look for runtime permission management, and it is there.. I must've modified the MaterialFilePicker library
  • ..here
  • here are the important checkpoints that pertain to runtime permission checks:
  • where the check occurs when the Activity opens
  • where the check occurs if Android version is >= 6.0
  • where the app continues on its merry way after permission is granted
  • compared to the original unmodified Activity that doesn't include any such checks
• also, I now remember that I did test this app on a 10" Lenovo tablet that's running some flavor of Android 6.x ..and it worked well
• so, my initial guess was wrong..
  • I'm going to need to ask for your help to figure out what the real problem could be..
    1. did the app work when it was first installed?
       • is the crash the result of a particular stream URL?.. or did it just never work at all?
    2. do you have an app on your device that allows you to filter Logcat messages?
       • I tend to use this one
       • if you could filter messages by the type error and/or the string rtsp.. could you help me to track down the source of the problem?

[warren-bank]

Oh.. wait.. I just re-read what you said in your issue..

Please clarify my understanding:

1. did my release build of this app crash on your device?
2. or did you try to upgrade ExoPlayer to the newest official stable release (which doesn't include support for RTSP).. build your own modified version.. and did that build crash on your device?

[CMingTseng]

Dear Sir

Thx your answer

this is my doing { try to upgrade ExoPlayer to the newest official stable release (which doesn't include support for RTSP).. build your own modified version.. and did that build crash on your device }

and

build your own modified version <--- base your develop very thx

i try modify it can pass building apk

but when playing get Client null ---> crash

THX

[warren-bank]

ok.. then you can ignore pretty much everything that I said in my 1st reply; the only important take-away is that if you want to update ExoPlayer and build your own apk.. then you'll need to pull from the HEAD of this dev branch.. and that will remain the case until the corresponding PR is merged into master (of the official repo).

[CMingTseng]

@warren-bank

i fork and modify

can help me ?

https://github.com/CMingTseng/Android-RTSP-IPCam-Viewer/tree/dev_neo

THX

[CMingTseng]

ok.. then you can ignore pretty much everything that I said in my 1st reply; the only important take-away is that if you want to update ExoPlayer and build your own apk.. then you'll need to pull from the HEAD of this dev branch.. and that will remain the case until the corresponding PR is merged into master (of the official repo).

@warren-bank i also check tresvecesseis version

but the version is too old !!

it lost very ....

and it version can not play rtsp !! <--- i do not know why !! it can pass build

your version it close release-v2 <-- better !!

can help me ?

THX

[warren-bank]

a few thoughts..

• tresvecesseis (and team) are super heros!!

  • the work they did is amazing
  • there is no my version
  • as the "credits" section in the README indicates, my repo contains a snapshot of the library written by tresvecesseis (and team) at commit 865ced0
  • this app simply adds some UI that makes use of their work
  • the current state of their library has made a lot of improvements since that snapshot

• they include a lot of extensions that (for example) the "main" demo app uses

  • this is all a part of the official ExoPlayer repo
  • I intentionally did not include (nor use) any of these extensions in the app

• as for updating ExoPlayer..

  • I'll copy over an updated snapshot from the dev branch and release a new version/build
  • probably later today.. possibly tomorrow

• as for your repo/crashes..

  • I took a quick glance at the commits and don't really follow what you were trying to do
  • after I push my update, you may want to rebase.. though I'd suggest that you avoid the ExoPlayer library directory.. since it will contain the most recent version.. from tresvecesseis (and team)

• as for your pull request..

  • I'm glad you find this repo useful
  • I'm not going to merge any of these commits into my repo, but you're of course free to do whatever you like in yours

[CMingTseng]

very sorry

My English is awful

Can't express my meaning well

I clone https://github.com/tresvecesseis/ExoPlayer/tree/dev-v2-rtsp-test <-- branch dev-v2-rtsp-test

But this version

Cannot play RTSP stream <--- pass build apk

I manually compared the differences between you and tresvecesseis_dev-v2-rtsp-test

Your version is revised / added a lot in the RTSP ( if need i can list )

The version of tresvecesseis_dev-v2-rtsp-test seems to be quite old.

There is also a composition of TransferListener in UdpDataSource/BaseDataSource

But this has been @Deprecated in later versions

and the new version

maybe DRM ? so UdpDataSource is final & SampleQueue need DrmSessionManager

THX

[warren-bank]

here is what I came up with.

The library in tresvecesseis fork is a little behind the official master. I would give those guys some time to iron it out; master just released a bunch of breaking changes.

My version is a bit of a hack.. attempting to merge the conflict between the two code-bases. For a while, it felt like a game of whack-a-mole.. for every API I patched.. there would be 2 new errors. Total waste of time.. but the apk works.. so I guess that's something :)

[CMingTseng]

Dear Sir

1. i try use & modify your new version

if use your core & ui library at Google Exoplayer Demo app

will get

AGPBI: {"kind":"error","text":"Program type already present: com.google.android.exoplayer2.AudioBecomingNoisyManager$AudioBecomingNoisyReceiver","sources":[{}],"tool":"D8"} com.android.builder.dexing.DexArchiveMergerException: Error while merging dex archives: Learn how to resolve the issue at https://developer.android.com/studio/build/dependencies#duplicate_classes. Program type already present: com.google.android.exoplayer2.AudioBecomingNoisyManager$AudioBecomingNoisyReceiver

but i check AudioBecomingNoisyManager AudioBecomingNoisyReceiver

2. if not modify just unzip & clean and build project (v02.01.00-alpha.01)

i can not look any rtsp (but logcat show message the application handshake rtsp )

THX

[warren-bank]

1. regarding updating the rest of tresvecesseis ExoPlayer fork..
   including modified versions of official demos
   • I made a comment in the corresponding open PR.. if they ask for assistance, then I will
   • seems that Google has no intention to merge this library..
     not sure how much maintenance it's going to see from the community
2. regarding building the updated apk from my v02.01.00-alpha.01 tag
   • works for me
     • no errors building
     • rtsp streams play fine

fwiw.. duplicate classes implies that you're importing the ui library twice; you should check your code.

[CMingTseng]

1. regarding updating the rest of tresvecesseis ExoPlayer fork..including modified versions of official demos

   • I made a comment in the corresponding open PR.. if they ask for assistance, then I will
   • seems that Google has no intention to merge this library..not sure how much maintenance it's going to see from the community

2. regarding building the updated apk from my v02.01.00-alpha.01 tag

   • works for me

     • no errors building
     • rtsp streams play fine

fwiw.. duplicate classes implies that you're importing the ui library twice; you should check your code.

Dear Sir

as general develop

we . like use jenter / bintray to get library

like this :

dependencies { implementation group: 'com.google.android.exoplayer', name: 'core', version: '2.9.2' implementation "com.google.android.exoplayer:ui:2.9.2" }

as you say { . seems that Google has no intention to merge this library ..}

so i try to export & refactoring the RTSP library as Google project Structure

let other develop can use

dependencies { implementation group: 'com.google.android.exoplayer', name: 'core', version: '2.9.2' implementation "com.google.android.exoplayer:ui:2.9.2" implementation group: 'com.google.android.exoplayer', name: 'extra-core', version: '0.0.1' implementation "com.google.android.exoplayer:extra-ui:0.0.1" implementation "com.google.android.exoplayer:extension-sdp:0.0.1" implementation "com.google.android.exoplayer:extension-rtp:0.0.1" implementation "com.google.android.exoplayer:extension-rtsp:0.0.1" }

it seem ok ?? !! <--- pass build apk

But i can not play RTSP ?? (it seem work i can see logcat get information )

not any streaming . show at screen !!!

{

01-09 12:19:19.379 13457-13659/com.github.warren_bank.rtsp_ipcam_viewer V/Receiver: RTSP/1.0 200 OK CSeq: 3 Transport: RTP/AVP;unicast;client_port=59446-59447;server_port=50024-50025;ssrc=DA8B1BCB;mode="PLAY" Server: GStreamer RTSP server Session: u3wAm6BMU3DXa$gJ; timeout=60 Date: Thu, 09 Jan 2020 04:19:19 GMT 01-09 12:19:19.388 13457-13660/com.github.warren_bank.rtsp_ipcam_viewer V/Sender: PLAY rtsp://8.42.69.117:554/axis-media/media.amp?videocodec=h264&resolution=1280x720 RTSP/1.0 CSeq: 4 User-Agent: ExoPlayerLib/2.11.1 (Media Player for Android) Session: u3wAm6BMU3DXa$gJ; Range: npt=0.000- Scale: 1.0

}

can fixed ?

PS . your v02.01.00-alpha.01 ---> some devices ok . some devices only handshake rtsp no streaming at screen

THX

[warren-bank]

Please don't take this the wrong way.. but until somebody on tresvecesseis dev team asks me for a contribution.. I'm done making changes.

If they released their code under a suitable public license.. then I suppose that you're free to publish your own version. Personally, I think that's disrespectful to the original authors.. considering they've been trying to get the code merged for a long time now, and if anybody deserves proper credit.. they do.

OK.. that's about all I have to say on the topic.

[CMingTseng]

now Exoplayer office support RTSP

https://exoplayer.dev/rtsp.html

[warren-bank]

Hi. I just updated ExoPlayer to r2.16.0 ..which is the most recent stable release. As you said, RTSP is now officially supported.. so the experimental dependency is no-longer needed.