search

warren-bank / Android-WebMonkey

No-frills light-weight Android web browser with support for Greasemonkey userscripts.
https://warren-bank.github.io/Android-WebMonkey/index.html
GNU General Public License v2.0
105 stars 24 forks source link

When "use strict" , windowProxyHander set will throw exception #19

Closed luomoxu closed 5 days ago

luomoxu commented 6 days ago

In line https://github.com/warren-bank/Android-WebMonkey/blob/29d9f64e6e94273529cf657486e20d1146fce5bc/android-studio-project/libs/webview-gm-lib/src/main/res/raw/js_closure_2_es6#L84

set must return true or false

maybe use strict can be the default in test case

warren-bank commented 6 days ago

nice catch.. apparently, this method should return a boolean to indicate success/failure thanks!