search

warrencxw / pe

0 stars 0 forks source link

Incorrect syntax for arrow label #14

Open warrencxw opened 2 years ago

warrencxw commented 2 years ago

image.png

split fullCommand String is an invalid syntax for method calls. As a developer, I would be really confused when referencing this sequence diagram, wondering if the method called here is split, fullCommand, splitFullCommandString? Or is fullCommand just a String object here?

nus-se-bot commented 2 years ago

Team's Response

Agree that the line could be changed to split fullCommand:String for better uniformity, but as it is, it can also be interpreted as "splitting the String called fullCommand", which is what was intended. Thus, it wouldn't cause much confusion unless you read too much into it.

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Low]

Reason for disagreement: [replace this with your explanation]