warrencxw / pe

0 stars 0 forks source link

Incorrect usage of parallel paths blocks in sequence diagram #17

Open warrencxw opened 2 years ago

warrencxw commented 2 years ago

image.png

The DG implies that the Timer methods are all parallel on a separate thread from the other commands, but this is not clear in the sequence diagrams, as there is no second part of the block which indicates what is running in parallel to the segment put in the parallel block, as per the text book shown below.

image.png

soc-se-bot commented 2 years ago

Team's Response

We admit that the second block of the parallel frame is missing. However, the explanation for the sequence diagram states that all methods from Countdown run in parallel with commands from other objects:

image.png

Since, we have explicitly stated this in the explanation right below the diagram, we believe the users would still be able to understand what is going on in the parallel frame. We have also lowered the severity level to low accordingly.

In case the term Timer is argued to be ambiguous, we have defined the terms in the Glossary:

image.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: image.png

According to the module website, this issue does not appear to be a valid use case for the NotInScope response. I understand that the explanation does explain what methods are run in parallel as other commands, but it does not change the fact that the sequence diagram is of invalid syntax and as such misleading and confusing.


:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: [replace this with your explanation]