Fix issue where invalid regex crashes the app & display regex error message to user - Githubissues

warrenday / graphql-network-inspector

A better network inspector for viewing and debugging GraphQL requests.

MIT License

485 stars 47 forks source link

Fix issue where invalid regex crashes the app & display regex error message to user #58

Closed KylePinkerton closed 2 years ago

KylePinkerton commented 2 years ago

Description

Previously when entering an invalid regex to the "Filter" input on the toolbar, the app would crash. This PR fixes that issue as well as adding functionality so that the regex error message is shown to the user when they are in the regex filter mode.
Added tests.

Screenshots

Previous Behaviour (dark mode)

New Behaviour (dark mode)

Previous Behaviour (light mode)

New Behaviour (light mode)

Provide a screenshot or gif of the new feature in both dark and light mode.

Checklist

[x] Displays correctly with both dark and light mode (see useTheme.ts)
[x] Unit/Integration tests added