search

warrenday / graphql-network-inspector

A better network inspector for viewing and debugging GraphQL requests.
MIT License
485 stars 47 forks source link

handle persisted queries #81

Closed Odonno closed 1 year ago

Odonno commented 1 year ago

Description

This PR should fix #70 and #71. The app now detects persisted queries (GET requests).

Note that each framework handles persisted queries differently, I only handle persisted ones I know. This can be further improved by submitting new issues for each case.

Screenshot

Provide a screenshot or gif of the new feature in both dark and light mode.

image

image

Also note that on this screenshot, there is 1 POST GraphQL query and there are 3 GET GraphQL queries.

Checklist

warrenday commented 1 year ago

Hey @Odonno Thanks for raising the PR. Code looks great.

Odonno commented 1 year ago

That was fast! :)

Just a note. I have added a third block in the RequestView component. After Query and Variables, you can now see Extensions. This view is nice but I think we can improve it a little bit. I could try something on another PR if that's ok with you?

warrenday commented 1 year ago

If extensions are available we already show them in a fourth tab.

If you mean the info to show individual resolver timings?

Odonno commented 1 year ago

I don't think so. I mean the info about the persisted query. This is json data you can see on my screenshot (after Variables).