search

warrensbox / terraform-switcher

A command line tool to switch between different versions of terraform (install with homebrew and more)
https://tfswitch.warrensbox.com
MIT License
1.33k stars 133 forks source link

Move away from golang openpgp #439

Open MatthewJohn opened 1 month ago

MatthewJohn commented 1 month ago

According to the docs: https://pkg.go.dev/golang.org/x/crypto/openpgp, the library has been deprecated:

Deprecated: this package is unmaintained except for security fixes. New applications should consider a more focused, modern alternative to OpenPGP for their specific task. If you are required to interoperate with OpenPGP systems and need a maintained package, consider a community fork. See https://golang.org/issue/44226.

It seems that quite a few have suggested/have moved to https://github.com/ProtonMail/gopenpgp This arose whilst trying to write some tests: c25d83189cbec7c3786eff81b7442318026be13e

yermulnik commented 1 month ago

Just cross-posting for visibility: https://github.com/warrensbox/terraform-switcher/pull/435#issuecomment-2137136952

I wonder if these tests can immediately start using Proton Mail's library to see if it resolves the issues

I'd say go ahead with it.

MatthewJohn commented 3 weeks ago

Re-opening as gopenpgp was only used for some mocking tests - the original use of openpgp is still in use