warriordog / ActivityPubSharp

Modular implementation of ActivityPub in C#
https://warriordog.github.io/ActivityPubSharp/
Mozilla Public License 2.0
46 stars 10 forks source link

ASActor.Endpoints breaks our model #26

Closed warriordog closed 1 year ago

warriordog commented 1 year ago
  1. ActorEndpoints should not be an ASType
  2. It's linkable (type is Object | Link) but the type is not an AS type
warriordog commented 1 year ago

I think we'll need to special-case this. Maybe we should create a general-purpose LinkOrAnyConverter<T> since this is so common? Or modify LinkableConverter<T> to allow any T, then manually apply it here?

warriordog commented 1 year ago

Fixed by making ActorEndpoints a regular object and allowing Linkable<T> to have any T.