ASObject: Url does not support a list

warriordog / ActivityPubSharp

Modular implementation of ActivityPub in C#

https://warriordog.github.io/ActivityPubSharp/

Mozilla Public License 2.0

46 stars 10 forks source link

ASObject: Url does not support a list #47

Closed warriordog closed 1 year ago

warriordog commented 1 year ago

Currently, ASObject.Url is typed as ASLink | null, but it should be List<ASLink> | ASLink | null. List -> T conversion is already handled by the globally-registered LinkableConverter, so this change will likely be as simple as changing the type to List<ASLink>?. Tests are needed to ensure that everything works as expected.

CreggHancock commented 1 year ago

Since #37 was blocked while I wait to make sure I'm going the right way with it I went ahead and took care of this one. Hope it wasn't already claimed, and if so I'm sorry!

warriordog commented 1 year ago

@CreggHancock That's totally fine and appreciated! I try to keep the "assignees" list up to date on smaller issues like this. As long as that's blank, and the issue isn't about key architecture decisions or something, then its probably fair game.