search

warriordog / ActivityPubSharp

Modular implementation of ActivityPub in C#
https://warriordog.github.io/ActivityPubSharp/
Mozilla Public License 2.0
46 stars 10 forks source link

Issue#70 #76

Closed viktoriussuwandi closed 1 year ago

viktoriussuwandi commented 1 year ago

fix #70

Hi warriordog, This is my PR for this issue, please check it out

warriordog commented 1 year ago

@viktoriussuwandi Hello, thank you for the PR! Are some of the changes missing? Many of the types are not updated, and the renamed APTypeAttribute class isn't in any of the commits.

warriordog commented 1 year ago

@viktoriussuwandi Ah, I just noticed that this is a draft PR. Sorry!

viktoriussuwandi commented 1 year ago

no worries @warriordog, I'll do it step by step untill all files covered, thanks for your advice :)

viktoriussuwandi commented 1 year ago

Hi @warriordog, I think it is ready to review, just lemme know if there is still need to be updated

warriordog commented 1 year ago

@viktoriussuwandi thank you! Reviewing now

warriordog commented 1 year ago

@viktoriussuwandi this looks good now, just needs a rebase. I can do that part myself, if you'd like. Just let me know

viktoriussuwandi commented 1 year ago

Thanks for the opportunity @warriordog, I leave the rest (rebase part) for you :)

warriordog commented 1 year ago

Merged in #107, for technical reasons