Closed viktoriussuwandi closed 1 year ago
@viktoriussuwandi Hello, thank you for the PR! Are some of the changes missing? Many of the types are not updated, and the renamed APTypeAttribute
class isn't in any of the commits.
@viktoriussuwandi Ah, I just noticed that this is a draft PR. Sorry!
no worries @warriordog, I'll do it step by step untill all files covered, thanks for your advice :)
Hi @warriordog, I think it is ready to review, just lemme know if there is still need to be updated
@viktoriussuwandi thank you! Reviewing now
@viktoriussuwandi this looks good now, just needs a rebase. I can do that part myself, if you'd like. Just let me know
Thanks for the opportunity @warriordog, I leave the rest (rebase part) for you :)
Merged in #107, for technical reasons
fix #70
Hi warriordog, This is my PR for this issue, please check it out