Project 1: Ordered collections don't work (regression)

warriordog / ActivityPubSharp

Modular implementation of ActivityPub in C#

https://warriordog.github.io/ActivityPubSharp/

Mozilla Public License 2.0

46 stars 10 forks source link

Project 1: Ordered collections don't work (regression) #86

Closed warriordog closed 1 year ago

warriordog commented 1 year ago

(De)serialization doesn't work for ordered collections.

warriordog commented 1 year ago

The solution might be as simple as breaking the inheritance between them. Something like this:

ASEntity (abstract)
  CollectionEntityBase (abstract)
    ASCollectionEntity
    ASOrderedCollectionEntity
    ASCollectionPageEntity
    ASOrderedCollectionPageEntity

ASType (abstract)
  CollectionBase (abstract)
    ASCollection
    ASOrderedCollection
    ASCollectionPage
    ASOrderedCollectionPage

When we implement #43, the ergonomics will be just fine.

warriordog commented 1 year ago

actually the common base is more trouble than its worth for right now. We can revisit that part later.

warriordog commented 1 year ago

Fixed, at least for now. We can revisit later.