Create flexible semantic wrapper for App sections

warsawjs / topics-manager

App for choosing subjects and signing up as trainers for workshops

MIT License

10 stars 1 forks source link

Closed greglobinski closed 6 years ago

greglobinski commented 6 years ago

create Container component which renders to different tags: <div />, <section />, <header /> or <footer /> depending on props.type value
Add react-test-rendrer to devDependencies, I found it easier to test the Container component with this library rather than enzyme,
Use Container to wrap TopicsContainer, TopBar, Header and WorkshopForm with properly chosen types.

greglobinski commented 6 years ago

@Tuhaj I'm not sure if I've done the rebase the way you expected. If not, could you please give me some guidelines? It was my first rebase ever :)

Tuhaj commented 6 years ago

Thanks @greglobinski good work 👍