warsawjs / topics-manager

App for choosing subjects and signing up as trainers for workshops
MIT License
10 stars 1 forks source link

Feature/gh login #19

Closed kgajowy closed 6 years ago

kgajowy commented 6 years ago

@Tuhaj Please let me know if you still have any questions, as I would like to close this PR and continue in https://github.com/warsawjs/topics-manager/pull/20 (as this one has a history of commits which do not belong there - therefore I moved it to different branch)

Tuhaj commented 6 years ago

@kgajowy sorry! no go yet! We have a syntax error in the depending library

Tuhaj commented 6 years ago

screen shot 2018-06-06 at 18 08 45

Tuhaj commented 6 years ago

the login process works well, but this doesn't look nice ;-) On master there was no error like that, can you check if you can also see it on your side? Moreover please run npm install again, cause I have a different package-lock.json

-        "string_decoder": {
-            "version": "1.1.1",
-            "resolved": "https://registry.npmjs.org/string_decoder/-/string_decoder-1.1.1.tgz",
-            "integrity": "sha512-n/ShnvDi6FHbbVfviro+WojiFzv+s8MPMHBczVePfUpDJLwoLT0ht1l4YwBCbi8pJAveEEdnkHyPyTP/mzRfwg==",
-            "requires": {
-                "safe-buffer": "5.1.2"
-            }
-        },
         "string-argv": {
             "version": "0.0.2",
             "resolved": "https://registry.npmjs.org/string-argv/-/string-argv-0.0.2.tgz",
@@ -12411,6 +12403,14 @@
                 }
             }
         },
+        "string_decoder": {
+            "version": "1.1.1",
+            "resolved": "https://registry.npmjs.org/string_decoder/-/string_decoder-1.1.1.tgz",
+            "integrity": "sha512-n/ShnvDi6FHbbVfviro+WojiFzv+s8MPMHBczVePfUpDJLwoLT0ht1l4YwBCbi8pJAveEEdnkHyPyTP/mzRfwg==",
+            "requires": {
+                "safe-buffer": "5.1.2"
+            }
+        },
         "stringify-object": {
             "version": "3.2.2",
             "resolved": "https://registry.npmjs.org/stringify-object/-/stringify-object-3.2.2.tgz",
kgajowy commented 6 years ago

Will continue in https://github.com/warsawjs/topics-manager/pull/20