Open GoogleCodeExporter opened 9 years ago
The only little problem is... we don't have any way to detect a double-click.
This
need setting up a timer on each click on a color, and seeing if another clicks
at
the same place occurs. Or maybe we can just go for "a click on an already
selected
color", but that would mean opening the palette like that would also select the
color.
Original comment by pulkoma...@gmail.com
on 4 Feb 2009 at 7:55
Sure it would select it. "a click on an already selected color" would work just
fine,
apart from possible accidental openings of palette :D Can't really say if that
can
happen to anyone, I'll try to pay attention whether I click on already selected
colors.
This is not really the most important thing, so if it's complicated, don't
sweat it.
More of an issue of comfort than of functionality, really.
Original comment by ilija.melentijevic
on 4 Feb 2009 at 8:06
I was also thinking of opening the palette when clicking on the "selected
colors
preview" just above the palette button.
Maybe we could do the following:
-Clicking the palette button open the pal editor with no colors selected
-Clicking on the fg/bg preview open the pal with the fg>bg range selected
-Clicking on the fg color with left click opens the pal editor with fg color
selected
-Clicking on the bg color with right click opens the pal editor with bg color
selected. This last one may not be a good idea, as there is no visual
indication
that the bg color is already selected in the palette.
Original comment by pulkoma...@gmail.com
on 4 Feb 2009 at 8:41
Double-click can be detected...it's quite messy because we need a handful of
variables (static in input.c) to detect the sequence:
1) click
2) no movement
3) release (start timer)
4) no movement
5) click (check timer)
6) no movement
7) release
Note that the first click will already have selected the color under cursor as
FG,
and opening the palette already selects the FG color initially.
Original comment by yrizoud
on 4 Feb 2009 at 8:53
Honestly there SHOULD be a visual indication for bg index. It is very uncommon
that
there isn't. I already spoke to yrizoud about that.
Also I'm against no colors being selected. Due to different arrangments of
colors in
panel palette and popup palette it is sometimes easier to locate the color you
want
in one of the two. So, the FG color should remain selected when clicking PAL
button.
Not sure about the fb>bg range, but why not?
Original comment by ilija.melentijevic
on 4 Feb 2009 at 8:54
Original comment by pulkoma...@gmail.com
on 5 Feb 2009 at 8:39
Original comment by yrizoud
on 5 Feb 2009 at 4:07
Original comment by pulkoma...@gmail.com
on 11 Feb 2009 at 8:32
Original comment by pulkoma...@gmail.com
on 7 Apr 2009 at 12:53
Original comment by pulkoma...@gmail.com
on 7 Apr 2009 at 1:09
fixed in r793
Original comment by pulkoma...@gmail.com
on 8 May 2009 at 8:54
Original issue reported on code.google.com by
ilija.melentijevic
on 4 Feb 2009 at 7:35