Save settings prior to exiting the app

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Update something in your Settings panel
2. Using task manager, kill peerblock.exe
3. Restart PeerBlock

What is the expected output? What do you see instead?
- Expected:  When you restart the program, your new settings from Step 1
should still be in effect.
- Actual:  The settings are the same as they were before you made the
changes in Step 1.

Currently, PeerBlock - like PeerGuardian before it - doesn't save your
settings until it successfully exits.  This may be a "feature", to protect
you against bad settings torching your install; however, it causes
confusion for users especially since PeerBlock doesn't always exit
successfully when the machine is rebooted.

We should either save settings straightaway, or at a minimum give a "Save
Changes" button.  If we're really concerned about bad settings preventing
us from starting up we can save a backup copy of the .conf file when we
first start.  Create a "peerblock_started" file at program start, and
delete this file when we successfully exit.  If we find this file when we
restart, we can try to reload the old saved config and try using it that way.

Original issue reported on code.google.com by peerbloc...@gmail.com on 1 Aug 2009 at 2:09

[GoogleCodeExporter]

Bumping up priority of this one due to user interest, and since I think it 
might make
people's lives easier.  Should be less of an issue now that we're more stable 
and
generally terminate successfully - even during shutdown/reboot - but I'd like 
to see
it get in before Release 1.0.

Original comment by peerbloc...@gmail.com on 12 Sep 2009 at 3:22

• Added labels: Priority-Medium
• Removed labels: Priority-Low

[GoogleCodeExporter]

This issue was closed by revision r154.

Original comment by peerbloc...@gmail.com on 14 Sep 2009 at 4:28

• Changed state: Fixed

[GoogleCodeExporter]

In order to resolve this without too much code change at this point, I opted to
simply create a Save button on the Settings panel.  Clicking this button will 
write
your config to-disk immediately, instead of waiting for the program to 
successfully
terminate.

Future development may include better handling of this button, for example only
enabling it if the config's actually changed since it was last written.  Those
changes are beyond the scope of this issue though, and will be considered as 
part of
Issue 98 instead.

Original comment by peerbloc...@gmail.com on 14 Sep 2009 at 4:30