PeerBlock taking too long to exit while machine rebooting

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Start PeerBlock
2. Make changes to some of your settings
3. Before manually-exiting the program, reboot your machine
4. After reboot, restart PeerBlock again

What is the expected output? What do you see instead?
- Expected: The settings changes should be saved.
- Actual: The settings changes were NOT saved, because PeerBlock didn't
shut down successfully.

Not sure if this is a problem on all machines, but a few users have
reported this "saving settings" problem, presumably caused by this
theoretical bug.  Need to try to repro it, and gather some more data on
what's going on during shutdown.

Original issue reported on code.google.com by peerbloc...@gmail.com on 1 Aug 2009 at 2:14

[GoogleCodeExporter]

Save config before doing anything else when closing. Removed unnecessary 
creation of 
pgfilter (possible slowing down the saving).

Should put this in another interim release so users who are experiencing this 
can 
verify it works for them.

Original comment by nightstalkerz on 21 Aug 2009 at 11:15

Attachments:

• issue38.patch

[GoogleCodeExporter]

Original comment by peerbloc...@gmail.com on 22 Aug 2009 at 1:11

• Changed state: Started

[GoogleCodeExporter]

I don't see any "removed unnecessary creation of pgfilter" in the patch...  Was 
this
an older version patch-file or something?  ...or did you mean the
unnecessarily-duplicated call to g_config.Save()?

Original comment by peerbloc...@gmail.com on 22 Aug 2009 at 1:51

[GoogleCodeExporter]

It's on line 19 where we assign g_filter again.

There's only 1 place where g_config.Save() is called and it is at the top. The 
bottom 
one is just removing it.

The main change for this patch was to call g_config.Save() before doing 
anything else 
in the Main_OnDestroy() method.

Original comment by nightstalkerz on 22 Aug 2009 at 10:31

[GoogleCodeExporter]

Wow, yeah, I see it now.  Must have been delirious last night or something, I 
swear
the patch looked entirely different...  =;)

Will sanity test the fix then get it checked-in and pushed off to the Beta Team 
for
initial testing, will generate another Interim Release sometime after they have 
a
chance to bang away at it for a bit.

Thanks for the patch!

Original comment by peerbloc...@gmail.com on 22 Aug 2009 at 3:54

[GoogleCodeExporter]

Marking as Fixed with the r102 commit.  We can reopen the bug if it turns out 
otherwise.

Original comment by peerbloc...@gmail.com on 24 Aug 2009 at 12:46

• Changed state: Fixed