List Loading Fails in Japanese Windows Versions

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Install Peer Block on Japanese Windows
2. Load a custom list into the List Manager
3. Close Peer Block
4. Start Peer Block Again

What is the expected output? What do you see instead?
Expected: Peer Block loads the previously loaded Custom List without issue.
Actual: Peer Block reports the following error:

---------------
File not found
  Unable to open the list at "..￥..￥Documents and Settings￥USERNAME￥????
??￥Blocklists￥CUSTOMLIST.txt
---------------

What version of the product are you using? On what operating system?
Peer Block r93
Windows XP Professional (32-bit) [Japanese]

Please provide any additional information below.
This exact problem occurred in the latest Peer Guardian 2 (albeit with less 
graceful error handling).  The issue appears to be with the non-ascii 
characters included in Japanese filesystem paths.  With Japanese Windows 
(and other OSes?) the backslash in paths (\) is replaced by the yen symbol 
(￥).  This replacement appears to be a font-based replacement and not a 
lower-level OS change.  The problem occurs as Japanese characters are not 
correctly identified.  (The "??????" above is actually "デスクトップ", 
Japanese 
for "Desktop".)

*Peer Block (and Peer Guardian before it) appear to read the files 
correctly when initially loading them in the GUI.

WORKAROUND: Put the Blocklists in a path that does not include Japanese 
characters (ie a folder called "Blocklists" directly under C:).  The yen 
character appears to read correctly.  Japanese text itself, however, does 
not appear to be handled properly.

Original issue reported on code.google.com by ryunokok...@gmail.com on 22 Aug 2009 at 3:22

Attachments:

• CustomListLoadError.png

[GoogleCodeExporter]

A very similar error occurs when trying to edit and then save a file including 
Japanese text in the path.

What steps will reproduce the problem?
1. Load a custom list into the List Manager from a location that includes 
Japanese 
text in the path.
2. Select added list and click "Open List" in the List Manager.
3. Click "Save".

What is the expected output? What do you see instead?
Expected: Peer Block saves the Custom List without issue.
Actual: Peer Block reports the following error:

---------------
Uncaught exception
  An uncaught exception occured!
  This problem has been automatically reported to Phoenix Labs.  The report contains 
the following information:

  Build Number: 30908190093
  File: .￥listproc.cpp
  Line: 659
  Type: class p2p::p2p_error
  Message: unable to open file

  Thankyou for helping us improve PeerGuardian!
---------------

Please provide any additional information below.
Again, you can read the yen mark (￥) as a backslash (\).

WORKAROUND: Same as original bug post (load the blocklists from a path that 
doesn't 
include Japanese characters).

Original comment by ryunokok...@gmail.com on 22 Aug 2009 at 3:38

Attachments:

• CustomListSaveError.png

[GoogleCodeExporter]

I think this is probably to to incorrect use of ASCII in the path-handling code,
where we should be using Unicode (and Unicode-aware file I/O) instead.  We'll 
look
into it. 

Original comment by peerbloc...@gmail.com on 22 Aug 2009 at 3:47

• Changed state: Accepted