search

warvair / peerblock

Automatically exported from code.google.com/p/peerblock
Other
0 stars 1 forks source link

PB Crash - Flood of blocks #77

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Open a "bad" website eg riaa.org with HTTP set to allow
2. While the site is loading, trigger HTTP blocking

What is the expected output? What do you see instead?
It should be able to handle floods of blocks, not crash. "not responding"

What version of PeerBlock are you using? On what operating system? 32- or
64-bit? r131 on windows xp 32bit

Please provide any additional information below.  Make sure to attach
peerblock.log and/or any screenshots that would help explain your problem.

Dunno if it's reproducible. Did it on an old system (850MHz P3).

Original issue reported on code.google.com by Praese...@gmail.com on 30 Aug 2009 at 5:33

Attachments:

GoogleCodeExporter commented 9 years ago 
It's reproducible.

Appears that the pgfilter_base::setblockhttp is called from 2 threads (1 UI, 1 
not) and it caused a deadlock. Patch 
removes the mutex from that method. Also removes the mutex from the 
pgfilter_base::setblock for the same reason.

Doesn't look like there's any side effect of removing the mutex except that 
during heavy blocks, it will still 
allow/block for a bit of time after pressing the button. Possibly related to 
the pgfilter internal queue.

Original comment by nightstalkerz on 5 Sep 2009 at 8:02

Attachments:

GoogleCodeExporter commented 9 years ago 
Additional discussion taking place on the Dev Team forum; I think we may want to
create new mutexes instead of removing them from this code entirely.  

From early tests, looks like this fix may also resolve Issue 21 and Issue 82.

Original comment by peerbloc...@gmail.com on 8 Sep 2009 at 11:56

GoogleCodeExporter commented 9 years ago

Original comment by peerbloc...@gmail.com on 8 Sep 2009 at 11:58

GoogleCodeExporter commented 9 years ago

Original comment by peerbloc...@gmail.com on 8 Sep 2009 at 11:58

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago

Original comment by peerbloc...@gmail.com on 10 Sep 2009 at 1:39

GoogleCodeExporter commented 9 years ago 
This issue was closed by revision r137.

Original comment by peerbloc...@gmail.com on 10 Sep 2009 at 2:12

GoogleCodeExporter commented 9 years ago 
Issue 21 has been merged into this issue.

Original comment by peerbloc...@gmail.com on 10 Sep 2009 at 2:14

GoogleCodeExporter commented 9 years ago 
Issue 82 has been merged into this issue.

Original comment by peerbloc...@gmail.com on 10 Sep 2009 at 2:14

GoogleCodeExporter commented 9 years ago 
Issue 125 has been merged into this issue.

Original comment by peerbloc...@gmail.com on 26 Sep 2009 at 8:19