warwickh / plugin.audio.subsonic

Kodi plugin to stream music from Subsonic.
MIT License
61 stars 13 forks source link

Need update for kodi "matrix". #29

Closed Herbs851 closed 3 years ago

Herbs851 commented 3 years ago

Hi all,

It's all in the title. Is anyone motivated to update the plugin to make it compatible with Kodi 19 "matrix" ? Unless someone has managed to get it to work ???

Thanks in advance.

gordielachance commented 3 years ago

Hi; I don't use Subsonic anymore so someone will have to do the work... I can transfer this repo if needed.
Good luck !

Herbs851 commented 3 years ago

Hi, I do not use subsonic but its fork airsonic. However, the plugin was working properly until now. Thanks for your answer ;)

Stele77 commented 3 years ago

A workaround that is possible AFAIK: Install "Ampache" e.g. with Docker, and then use the Subsonic/Airsonic/Airsonic-Advanced/Whatever as "remote catalog" in Ampache. And the install the Ampache Kodi Matrix Addon from Kodi repo and connect to Ampache. Have not yet tried this myself, but should work in theory. Still so sad to not be able to use the Subsonic Kodi Addon, especially not that after Airsonic vanilla has been a stalled/dead project, its fork Airsonic-Advanced has been progressing amazingly and re-energized the Airsonic community again. Hope someone who can code is able to give this addon some love.

Herbs851 commented 3 years ago

Thanks for the tip. I started to update the plugin but my level in python is not very high. I'm fixing one error after another without even knowing if I'll eventually succeed. If I fail I will try your solution ;)

warwickh commented 3 years ago

I have a working fork at https://github.com/warwickh/plugin.audio.subsonic (works for me anyway) Feel free to give it a try.

gordielachance commented 3 years ago

So nice ! i’ll have a look. Also, I am not maintaining this repo anymore. Would you be interested by taking the ownership ?

Herbs851 commented 3 years ago

I have a working fork at https://github.com/warwickh/plugin.audio.subsonic (works for me anyway) Feel free to give it a try.

So good, I'll try it later today and get back to you. Thanks ;) !!!!

Herbs851 commented 3 years ago

Hi again,

I did some tests on a VM with kodi newly installed.

If I install these 2 modules :

https://mirrors.kodi.tv/addons/matrix/script.module.dateutil/ https://mirrors.kodi.tv/addons/matrix/script.module.future/

it doesn't work.

image

If I install only the dateutil module and with a "pip3 install future" it works.

Is it normal ? or I missed something ?

Herbs851 commented 3 years ago

I think I've found it.

To use script.module.future-0.18.2+matrix.1 you have to add this line in addon.xml :

<import version="0.18.2" addon="script.module.future"/>

And then it works ;)

warwickh commented 3 years ago

Yes, you're right. That's a new requirement from the simpleplugin update. I must have had it on my machine already.

Thanks for testing. I've updated it now.

I'm happy to take over the repo. I use this plugin a bit, so will probably tweak it some more.

Herbs851 commented 3 years ago

I didn't do much, you did all the work.

And I thank you very much ;) !!!

gordielachance commented 3 years ago

Hi @warwickh, that is nice ! I'm trying to transfer the repo.

Could you 1 / make a pull request so I can merge your commits 2 / Once I'll have done it, you will need to delete your repo so I can give you the ownership : actually, it says "warwickh/plugin.audio.subsonic already exists"...

gordielachance commented 3 years ago

Merged ! I can transfer the ownership if you delete your current repo.

warwickh commented 3 years ago

Great. I've renamed my old repo, you can try to transfer any time now and it shouldn't clash.

gordielachance commented 3 years ago

Ok; i don’t get exactcly how it works. Now it says: warwickh already has a repository in the basilfx/plugin.audio.subsonic network

Do you know how to make this work ?

warwickh commented 3 years ago

Not sure, but I've completely deleted my version now so worth trying again.

gordielachance commented 3 years ago

Thanks and all the best !