search

wasabee-project / Wasabee-IITC

ENL DrawTools and Op Management
Apache License 2.0
30 stars 21 forks source link

Color picker close to its button on Chrome #249

Closed le-jeu closed 3 years ago

le-jeu commented 3 years ago

Makes chrome show the color picker close to its attached html element. fix #224 (chrome only afaik)

Side effect: I dropped the pending work on touch event and clean the html event that interfers with the color picker (click event and stopPropagation/preventDefault).

cloudkucooland commented 3 years ago

Yes. The touch work will require someone who has a passion for it, or already knows it. I just gave up on trying to make it work properly.

le-jeu commented 3 years ago

I don't understand what it is the purpose of this work now. What doesn't work correctly or should be improved?

TheMitch2 commented 3 years ago

Currently the color picker is in the upper left corner and it should be closer to the link dialog. image

le-jeu commented 3 years ago

@TheMitch2 I meant the "touch" work

cloudkucooland commented 3 years ago

I don't understand what it is the purpose of this work now. What doesn't work correctly or should be improved?

The buttons were wonky on touch devices. I was trying to find a way of making them better. This work setting aside the using click events in favor of using the full touch event framework. It was never any good. Other work made the buttons acceptable using clicks, making all this stuff unnecessary.

cloudkucooland commented 3 years ago

is this ready to merge?