search

wasabee-project / Wasabee-IITC

ENL DrawTools and Op Management
Apache License 2.0
30 stars 21 forks source link

Don't mix data state/values and wX strings or CSS classnames #270

Open le-jeu opened 3 years ago

le-jeu commented 3 years ago

267 raises an issue about mixing wasabee data state assigned/pending/completed/acknowledge with wX string of same name.

we need a pass to avoid this situation so that all wX strings are easily found by a simple search (wX(\s*"the strings" for instance)

thoses strings may be the only ones

le-jeu commented 3 years ago

https://github.com/wasabee-project/Wasabee-IITC/blob/e1b59f9ec7034955cfc006569922ef1038c5d3fc/src/code/dialogs/checklist.js#L130-L138

https://github.com/wasabee-project/Wasabee-IITC/blob/e1b59f9ec7034955cfc006569922ef1038c5d3fc/src/code/dialogs/checklist.js#L221-L227

TheMitch2 commented 3 years ago

Could all the state data be put into it's own section like the small screen things at the bottom?

le-jeu commented 3 years ago

no, that's not something to solve at wX level