search

wasabee-project / Wasabee-IITC

ENL DrawTools and Op Management
Apache License 2.0
30 stars 21 forks source link

Translation: Dialog box buttons for OK and Cancel #52

Closed D0BERMAXX closed 4 years ago

D0BERMAXX commented 4 years ago

I think they should also have translations

cloudkucooland commented 4 years ago

Yes, but they aren't quite so simple given how the underlying code works. I will investigate.

cloudkucooland commented 4 years ago

will require, at minimum, moving the button definitions out of the dialog creation.

"OK" and "Cancel" are defaults, there may be a JqueryUI value to adjust for them. We can use wX for all the others.

@D0BERMAXX can you identify all the dialogs which will need this?

D0BERMAXX commented 4 years ago

@cloudkucooland see link below to a google spreadsheet which contains the dialogs with OK and Cancel buttons https://docs.google.com/spreadsheets/d/1GAqFi-cz_sAZk-Rl48NCpxOGSVsKI1GoAZ5km1Mp0xc/edit?usp=sharing note: changed the file link

cloudkucooland commented 4 years ago

do we need the "OK" buttons on most of those dialogs? In (almost?) every case it only closes the dialog and the dialog control at the top does that already.

crystalwizard commented 4 years ago

it's more convenient for most people to click a large visible button than to close the x on the window. Plus most people expect that button and only use the x if the window seems to not be behaving correctly. I'd leave it.

On Tue, Apr 21, 2020 at 7:30 AM Scot Bontrager notifications@github.com wrote:

do we need the "OK" buttons on most of those dialogs? In (almost?) every case it only closes the dialog and the dialog control at the top does that already.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/wasabee-project/Wasabee-IITC/issues/52#issuecomment-617216361, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEI3PKTXIDXAUVNIT6IJ5LLRNWUW3ANCNFSM4LTY5VBA .

-- Visit my store on Teepublic https://www.teepublic.com/user/crystalwizard and grab something cool today!

cloudkucooland commented 4 years ago

I started on this today but got interrupted by the oh-so-freaking-urgent rate limiting on portal details. I'll come back to this later.

cloudkucooland commented 4 years ago

All those JqueryUI buttons should be translatable now. Please test.